From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_nand: fix crashing bug in nand read/write
Date: Thu, 7 Jun 2012 12:27:40 -0500 [thread overview]
Message-ID: <4FD0E48C.2060400@freescale.com> (raw)
In-Reply-To: <1339089558-22806-1-git-send-email-steve@sakoman.com>
On 06/07/2012 12:19 PM, Steve Sakoman wrote:
> Commit 418396e212b59bf907dbccad997ff50f7eb61b16 introduced a
> bug that causes nand read and nand write to crash in strcmp
> due to a null pointer.
>
> Root cause is that strchr(cmd, '.') returns a null pointer when
> the input string does not contain a '.'
>
> The strcmp function does not check for null pointers, resulting
> in a crash.
>
> Signed-off-by: Steve Sakoman <steve@sakoman.com>
Applied to u-boot-nand-flash, thanks!
This was missed in testing because U-Boot on PowerPC unfortunately has a
valid mapping at NULL.
-Scott
prev parent reply other threads:[~2012-06-07 17:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 17:19 [U-Boot] [PATCH] cmd_nand: fix crashing bug in nand read/write Steve Sakoman
2012-06-07 17:27 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD0E48C.2060400@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.