From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34792) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScuAD-00010x-8k for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:03:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScuA8-00015f-JG for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:03:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56637 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScuA8-00015C-Ca for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:03:16 -0400 Message-ID: <4FD1B1BF.20103@suse.de> Date: Fri, 08 Jun 2012 10:03:11 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1339054814-20939-1-git-send-email-pbonzini@redhat.com> <1339054814-20939-7-git-send-email-pbonzini@redhat.com> <4FD136B9.2060107@redhat.com> In-Reply-To: <4FD136B9.2060107@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 06/29] build: move libobj-y variable to nested Makefile.objs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , Paolo Bonzini , qemu-devel@nongnu.org Am 08.06.2012 01:18, schrieb Paolo Bonzini: > Il 07/06/2012 23:10, Blue Swirl ha scritto: >>> diff --git a/target-sparc/Makefile.objs b/target-sparc/Makefile.objs >>> index c574c9e..3556d13 100644 >>> --- a/target-sparc/Makefile.objs >>> +++ b/target-sparc/Makefile.objs >>> @@ -1 +1,7 @@ >>> -# still empty >>> +obj-y +=3D helper.o cpu.o >>> +obj-y +=3D fop_helper.o cc_helper.o win_helper.o mmu_helper.o ldst_h= elper.o >>> +obj-$(TARGET_SPARC) +=3D int32_helper.o >>> +obj-$(TARGET_SPARC64) +=3D int64_helper.o >>> +obj-$(TARGET_SPARC64) +=3D vis_helper.o >>> + >>> +$(obj)/op_helper.o: QEMU_CFLAGS +=3D $(HELPER_CFLAGS) >> >> Please remove. >=20 > Fixed, updated branch to commit 067ca6b. Thanks. Anthony, are you planning to pull this soon? This refactoring is blocking even the first batch of qom-next patches and any other series that touches Makefiles. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg