From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
t-kristo@ti.com, Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [PATCH] MFD: twl6040: Update Kconfig to avoid build breakage
Date: Fri, 08 Jun 2012 11:51:55 +0300 [thread overview]
Message-ID: <4FD1BD2B.6090200@ti.com> (raw)
In-Reply-To: <20120608083003.GI22557@sortiz-mobl>
Hi Samuel,
On 06/08/2012 11:30 AM, Samuel Ortiz wrote:
> Hi Peter,
>
> On Fri, Jun 08, 2012 at 09:35:00AM +0300, Peter Ujfalusi wrote:
>> twl6040 needs CONFIG_IRQ_DOMAIN to compile, without this we have:
>> drivers/mfd/twl6040-irq.c: In function 'twl6040_irq_init':
>> drivers/mfd/twl6040-irq.c:164:2: error: implicit declaration of function 'irq_domain_add_legacy'
>> drivers/mfd/twl6040-irq.c:165:11: error: 'irq_domain_simple_ops' undeclared (first use in this function)
>> drivers/mfd/twl6040-irq.c:165:11: note: each undeclared identifier is reported only once for each function it appears in
>>
>> Reported by: Randy Dunlap <rdunlap@xenotime.net>
>>
>> At the same time limit the twl6040 availability to ARM architecture since
>> it is unlikely that this chip is going to be used on other architectures.
> Right, but you're losing a lot of the linux-next build coverage.
> With a dependency on ARM, we may have missed the above build error for
> example. Would you mind removing that dependency ?
Yes. True that we miss some coverage due to depending on ARM here. I did
missed this since when I build for OMAP the IRQ_DOMAIN is selected by OF,
which is selected by OMAP. Even if I use randconfig for ARM I would not
noticed this since AFAIK ARM selects IRQ_DOMAIN also...
I'll resend in a minute without the ARM dependency.
--
Péter
prev parent reply other threads:[~2012-06-08 8:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 6:35 [PATCH] MFD: twl6040: Update Kconfig to avoid build breakage Peter Ujfalusi
2012-06-08 8:30 ` Samuel Ortiz
2012-06-08 8:51 ` Peter Ujfalusi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD1BD2B.6090200@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sameo@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.