From: Greg Ungerer <gregungerer@westnet.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: gerg@snapgear.com, linux-m68k@vger.kernel.org,
uclinux-dev@uclinux.org, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types
Date: Fri, 08 Jun 2012 19:13:48 +1000 [thread overview]
Message-ID: <4FD1C24C.5030108@westnet.com.au> (raw)
In-Reply-To: <CAMuHMdVvdqRsOSJj6bzZCiGfH-aMX=DKs6eh4assHRq21Jitow@mail.gmail.com>
Hi Geert,
On 06/08/2012 05:16 PM, Geert Uytterhoeven wrote:
> On Fri, Jun 8, 2012 at 7:28 AM,<gerg@snapgear.com> wrote:
>> From: Greg Ungerer<gerg@uclinux.org>
>>
>> The assembler entry code calls directly to the syscall_trace_enter() and
>> syscall_trace_leave() functions. But currently they are conditionaly
>> compiled out for the non-MMU classic m68k CPU types (so 68328 for example),
>> resulting in a link error:
>>
>> LD vmlinux
>> arch/m68k/platform/68328/built-in.o: In function `do_trace':
>> (.text+0x1c): undefined reference to `syscall_trace_enter'
>> arch/m68k/platform/68328/built-in.o: In function `do_trace':
>> (.text+0x4c): undefined reference to `syscall_trace_leave'
>>
>> Change the conditional check that includes these functions to be true for
>> the !defined(CONFIG_MMU) case as well.
>>
>> Signed-off-by: Greg Ungerer<gerg@uclinux.org>
>
> Acked-by: Geert Uytterhoeven<geert@linux-m68k.org>
>
> Hmm, should add syscall_trace support to M68KCLASSIC/MMU...
That would be nice :-)
Regards
Greg
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2012-06-08 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 5:28 [PATCH] m68k: make syscall_trace_enter/leave exist for non-MMU classic m68k types gerg
2012-06-08 7:16 ` Geert Uytterhoeven
2012-06-08 9:13 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD1C24C.5030108@westnet.com.au \
--to=gregungerer@westnet.com.au \
--cc=geert@linux-m68k.org \
--cc=gerg@snapgear.com \
--cc=gerg@uclinux.org \
--cc=linux-m68k@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.