Re: [Qemu-devel] [PULL] iov* function rework (one more time)

[Kevin Wolf <kwolf@redhat.com>]

Am 07.06.2012 19:53, schrieb Michael Tokarev:
> The following changes since commit 083dbf489d1b0592e910ecfb90b3858c23e49ab7:
> 
>   target-microblaze: fix swx build breakage (2012-06-07 10:12:00 +0200)
> 
> are available in the git repository at:
> 
>   git://git.corpit.ru/qemu.git mjt-iov
> 
> for you to fetch changes up to 85c5ece9bc0bd30f0573e43d1ddd756154ac6849:
> 
>   rewrite iov_send_recv() and move it to iov.c (2012-06-07 21:22:54 +0400)
> 
> ----------------------------------------------------------------
> Michael Tokarev (11):
>       virtio-serial-bus: use correct lengths in control_out() message
>       change iov_* function prototypes to be more appropriate
>       rewrite iov_* functions
>       consolidate qemu_iovec_memset{,_skip}() into single function and use existing iov_memset()
>       allow qemu_iovec_from_buffer() to specify offset from which to start copying
>       consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent
>       change qemu_iovec_to_buf() to match other to,from_buf functions
>       rename qemu_sendv to iov_send, change proto and move declarations to iov.h
>       export iov_send_recv() and use it in iov_send() and iov_recv()
>       cleanup qemu_co_sendv(), qemu_co_recvv() and friends
>       rewrite iov_send_recv() and move it to iov.c


I haven't reviewed the series in detail, and mostly ignored the cutils.c
implementation and usage in other subsystems, but as far as the block
layer is concerned:

Acked-by: Kevin Wolf <kwolf@redhat.com>

(Even though I don't agree that the new argument order of iov_from_buf()
is better, but that's probably a matter of taste and the series has
enough other good stuff)

Kevin