From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Scwff-0005IY-O0
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:44:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Scwfa-0007DP-UD
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:43:59 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:58143)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Scwfa-0007DB-O2
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:43:54 -0400
Message-ID: <4FD1D767.9090401@weilnetz.de>
Date: Fri, 08 Jun 2012 12:43:51 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1339149034-10163-1-git-send-email-jcmvbkbc@gmail.com>
	<CAJSP0QXdGwv6yiJ11R0apVkYRPUesC0VGtkVLiXphBFTfN_8BA@mail.gmail.com>
In-Reply-To: <CAJSP0QXdGwv6yiJ11R0apVkYRPUesC0VGtkVLiXphBFTfN_8BA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] xtensa_lx60: add missing #include
	"blockdev.h"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>, qemu-devel@nongnu.org

Am 08.06.2012 12:08, schrieb Stefan Hajnoczi:
> On Fri, Jun 8, 2012 at 10:50 AM, Max Filippov<jcmvbkbc@gmail.com>  wrote:
>> This should fix the following build failure:
>>
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c: In function 'lx_init':
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: warning: implicit declaration of function 'drive_get'
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: warning: nested extern declaration of 'drive_get'
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: 'IF_PFLASH' undeclared (first use in this function)
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: (Each undeclared identifier is reported only once
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:212: error: for each function it appears in.)
>> /home/buildbot/slave-public/block_mingw32/build/hw/xtensa_lx60.c:216: error: dereferencing pointer to incomplete type
>>
>> Signed-off-by: Max Filippov<jcmvbkbc@gmail.com>
>> ---
>>   hw/xtensa_lx60.c |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>


Strange, I don't see this problem here.

xtensa_lx60.c includes pc.h which includes fdc.h which includes blockdev.h,
so this patch should not be needed.

What went wrong in your build, or are your sources different from qemu 
git master?

Regards,
Stefan Weil