From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScyHT-00054g-22 for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScyHM-0003im-7L for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:27:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:42616 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScyHM-0003iJ-0a for qemu-devel@nongnu.org; Fri, 08 Jun 2012 08:27:00 -0400 Message-ID: <4FD1EF8F.4040403@suse.de> Date: Fri, 08 Jun 2012 14:26:55 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1337742502-28565-1-git-send-email-afaerber@suse.de> <1337742502-28565-5-git-send-email-afaerber@suse.de> <20120608082006.GA22512@thinkpad.mammed.net> <4FD1C1AF.2020208@suse.de> <4FD1D243.7090600@siemens.com> <4FD1D5A2.8090008@suse.de> <20120608113627.GB22512@thinkpad.mammed.net> In-Reply-To: <20120608113627.GB22512@thinkpad.mammed.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next 04/59] pc: Add CPU as /machine/cpu[n] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Jan Kiszka , Anthony Liguori , "qemu-devel@nongnu.org" , Igor Mammedov , Paolo Bonzini Am 08.06.2012 13:36, schrieb Igor Mammedov: > On Fri, Jun 08, 2012 at 12:36:18PM +0200, Andreas F=E4rber wrote: >> Am 08.06.2012 12:21, schrieb Jan Kiszka: >>> On 2012-06-08 11:11, Andreas F=E4rber wrote: >>>> >From what I understand about the x86 modeling, the only case this >>>> matters is if you hot-unplug CPU 0, right? Question is, what happens >>>> with the APIC then? I would guess the remaining n-1 CPUs still want = to >>>> access the APIC >>> >>> APICs are per-CPU, each has its own. >> >> [...] if each CPU always has its own APIC there's no reason to link<> >> them. It should be a child<> and it should be initialized in-place. >> >> Igor, can you please look into that? > Sure, Could you point to an example of creating a QOMified object in pl= ace, please? http://patchwork.ozlabs.org/patch/161497/ and Anthony's i440fx series. If I'm reading the code correctly then we'd need to add the APIC as a child of the CPU before its qdev initfn is called, i.e. in place of the current qdev pointer property. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg