From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sczfc-00029I-7m for qemu-devel@nongnu.org; Fri, 08 Jun 2012 09:56:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sczfa-0007Ct-0m for qemu-devel@nongnu.org; Fri, 08 Jun 2012 09:56:07 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:60284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SczfZ-0007CD-BX for qemu-devel@nongnu.org; Fri, 08 Jun 2012 09:56:05 -0400 Received: by pbbro12 with SMTP id ro12so2839456pbb.4 for ; Fri, 08 Jun 2012 06:56:02 -0700 (PDT) Message-ID: <4FD2046A.6080306@codemonkey.ws> Date: Fri, 08 Jun 2012 21:55:54 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <8efa27ccfaf23cc561d2583aa34ca834fd60c2f3.1338799936.git.jan.kiszka@siemens.com> <4FD0A548.3030005@suse.de> In-Reply-To: <4FD0A548.3030005@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 11/13] Move pci_parse_devaddr to qdev-properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Jan Kiszka , Alex Williamson , "Michael S. Tsirkin" , qemu-devel , Paolo Bonzini On 06/07/2012 08:57 PM, Andreas Färber wrote: > Am 04.06.2012 10:52, schrieb Jan Kiszka: >> We will some use this function also for property parsing, so move it >> over unmodified and rename it. >> >> Signed-off-by: Jan Kiszka > > These last three patches collide with Paolo's QOM properties > refactoring: qdev properties are being generalized to Object and on my > GitHub "realize" branch are being moved to qom/object-properties.c > (object.c in the original series). Please defer this change. Sorry, this doesn't scale. Patches need to go in when they're ready. If that means someone branch has a hard time rebasing, it probably means that branch should have attempted to merge sooner. If you want to work out the issues earlier, then setup a next branch or something like that. But don't expect someone else to hold up there work just because it conflicts with yours. That kind of ordering won't scale in a community as large as ours. Regards, Anthony Liguori > > Thanks, > Andreas >