From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
Date: Fri, 08 Jun 2012 14:32:42 -0500 [thread overview]
Message-ID: <4FD2535A.3050302@redhat.com> (raw)
w/o this change I was getting:
[ 742.376495] ODEBUG: object is on stack, but not annotated
[ 742.377007] ------------[ cut here ]------------
[ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[ 742.377007] Call Trace:
[ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
[ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
on a debug 3.4 kernel.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think it's right? :)
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 0f0df27..0be396d 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -2443,7 +2443,7 @@ xfs_alloc_vextent(
DECLARE_COMPLETION_ONSTACK(done);
args->done = &done;
- INIT_WORK(&args->work, xfs_alloc_vextent_worker);
+ INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker);
queue_work(xfs_alloc_wq, &args->work);
wait_for_completion(&done);
return args->result;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-06-08 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:32 Eric Sandeen [this message]
2012-06-08 19:44 ` [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent() Ben Myers
2012-06-08 23:12 ` Dave Chinner
2012-06-08 23:14 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD2535A.3050302@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.