From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48595)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1SdtpO-0001LA-5X
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 21:53:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1SdtpM-0008JB-CZ
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 21:53:57 -0400
Received: from [222.73.24.84] (port=33640 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1SdtpM-0008J1-0O
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 21:53:56 -0400
Message-ID: <4FD550A4.4030808@cn.fujitsu.com>
Date: Mon, 11 Jun 2012 09:57:56 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <1339076735-19796-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1339076735-19796-1-git-send-email-sw@weilnetz.de>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include
	file)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

At 06/07/2012 09:45 PM, Stefan Weil Wrote:
> dump.c was recently added to the code. It unconditionally
> includes sys/procfs which is not available with MinGW (w32, w64).
> 
> It looks like this file is not needed at all (tested on Linux),
> so I removed it completely.
> 
> Some other include statements are also redundant because they are
> already included in qemu-common, therefore they were removed, too.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>

Thanks for your fix. It is OK to me.

Wen Congyang

> ---
> 
> dump.* use GPL2 instead of GPL2+. Please fix that!
> 
> Regards,
> Stefan Weil
> 
> 
>  dump.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/dump.c b/dump.c
> index 0ca14f8..f44ce47 100644
> --- a/dump.c
> +++ b/dump.c
> @@ -12,10 +12,7 @@
>   */
>  
>  #include "qemu-common.h"
> -#include <unistd.h>
>  #include "elf.h"
> -#include <sys/procfs.h>
> -#include <glib.h>
>  #include "cpu.h"
>  #include "cpu-all.h"
>  #include "targphys.h"
> @@ -23,7 +20,6 @@
>  #include "kvm.h"
>  #include "dump.h"
>  #include "sysemu.h"
> -#include "bswap.h"
>  #include "memory_mapping.h"
>  #include "error.h"
>  #include "qmp-commands.h"