From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boaz Harrosh Subject: Re: [PATCH 00/21] vfs: atomic open v6 (part 2) Date: Mon, 11 Jun 2012 13:57:30 +0300 Message-ID: <4FD5CF1A.40807@panasas.com> References: <1338901832-14049-1-git-send-email-miklos@szeredi.hu> <20120610034921.GB30000@ZenIV.linux.org.uk> <20120610111056.GD30000@ZenIV.linux.org.uk> <20120610175605.GE30000@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Miklos Szeredi , , , , , , To: Al Viro Return-path: In-Reply-To: <20120610175605.GE30000@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 06/10/2012 08:56 PM, Al Viro wrote: > On Sun, Jun 10, 2012 at 12:10:56PM +0100, Al Viro wrote: > >> WARNING: I haven't even tried to boot it. It builds, but this is all I can >> promise at the moment. I'm about to fall down (it's 7am here already ;-/), >> will give it some beating when I get up. It almost certainly has bugs, so >> consider that as call for review and not much more. > > OK, it boots, mounts NFS and even manages to build a kernel on it. Which > probably would meet Linus' "it's perfect, ship it" criteria, so go ahead > and beat it up, folks. If the "manages to build a kernel on it" part involves a "git clone" first then I agree. From past bug I found that even if xfstest cthon and bunch of other testes pass, I still got data-corruption/bugs under "git clone linux, umount, mount, git status". It's my best test so far. (It needs to be a very big git tree with lots of history as well, like linux or gcc) Cheers Boaz