From: Wolfgang Grandegger <wg@grandegger.com>
To: Federico Vaga <federico.vaga@gmail.com>
Cc: Bhupesh SHARMA <bhupesh.sharma@st.com>,
"rubini@gnudd.com" <rubini@gnudd.com>,
"anilkumar@ti.com" <anilkumar@ti.com>,
"mkl@pengutronix.de" <mkl@pengutronix.de>,
"alan@lxorguk.ukuu.org.uk" <alan@lxorguk.ukuu.org.uk>,
Giancarlo ASNAGHI <giancarlo.asnaghi@st.com>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] c_can_pci: generic module for c_can on PCI
Date: Mon, 11 Jun 2012 16:21:19 +0200 [thread overview]
Message-ID: <4FD5FEDF.6020405@grandegger.com> (raw)
In-Reply-To: <CAH5GJ0qgQJZwO8xn-zkMA_mMhVM=uCjuCZjd8EbJr0NyE6i+tQ@mail.gmail.com>
On 06/11/2012 03:18 PM, Federico Vaga wrote:
> How we proceed?
> I submit my c_can_pci.c as a separated module, we create a
> c_can_platform_common.c,
> or we are thinking about a generic c_can.c as plaftorm driver?
I would accept your patch with the remaining fixes especially the new
register access methods introduced by the D_CAN support patch recently.
Any further improvements to the device abstraction and a more consistent
handling of the platform data or register access should be addressed by
sub-sequent patches.
Wolfgang.
next prev parent reply other threads:[~2012-06-11 14:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 20:59 [PATCH] STA2X11 CAN: CAN driver for the STA2X11 board Federico Vaga
2012-05-18 6:00 ` Wolfgang Grandegger
2012-05-26 8:36 ` Federico Vaga
2012-05-26 19:57 ` Wolfgang Grandegger
2012-06-04 13:32 ` generic module for c-can on pci Federico Vaga
2012-06-04 13:32 ` [PATCH RFC] c_can_pci: generic module for c_can on PCI Federico Vaga
2012-06-04 14:04 ` Marc Kleine-Budde
2012-06-12 14:25 ` Federico Vaga
2012-06-12 14:46 ` Marc Kleine-Budde
2012-06-12 14:53 ` Federico Vaga
2012-06-04 15:56 ` Alan Cox
2012-06-04 16:45 ` Alessandro Rubini
2012-06-11 13:51 ` Wolfgang Grandegger
2012-06-11 14:23 ` Alessandro Rubini
2012-06-04 16:45 ` Federico Vaga
2012-06-05 3:42 ` Bhupesh SHARMA
2012-06-05 11:19 ` Federico Vaga
2012-06-05 13:04 ` Bhupesh SHARMA
2012-06-05 13:13 ` Alessandro Rubini
2012-06-05 13:21 ` Marc Kleine-Budde
2012-06-05 13:30 ` Alessandro Rubini
2012-06-05 15:12 ` AnilKumar, Chimata
2012-06-05 16:50 ` Alessandro Rubini
2012-06-06 3:50 ` Bhupesh SHARMA
2012-06-11 13:18 ` Federico Vaga
2012-06-11 14:21 ` Wolfgang Grandegger [this message]
2012-06-05 13:22 ` Bhupesh SHARMA
2012-06-11 14:09 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD5FEDF.6020405@grandegger.com \
--to=wg@grandegger.com \
--cc=alan@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=anilkumar@ti.com \
--cc=bhupesh.sharma@st.com \
--cc=federico.vaga@gmail.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=rubini@gnudd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.