From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org ([70.85.31.133]:51426 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751454Ab2FKVhA (ORCPT ); Mon, 11 Jun 2012 17:37:00 -0400 Message-ID: <4FD664F8.4030800@wwwdotorg.org> Date: Mon, 11 Jun 2012 15:36:56 -0600 From: Stephen Warren MIME-Version: 1.0 To: Thierry Reding CC: linux-tegra@vger.kernel.org, Jesse Barnes , linux-pci@vger.kernel.org, Grant Likely , Rob Herring , devicetree-discuss@lists.ozlabs.org, Russell King , linux-arm-kernel@lists.infradead.org, Colin Cross , Olof Johansson Subject: Re: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT References: <1339427118-32263-1-git-send-email-thierry.reding@avionic-design.de> <1339427118-32263-9-git-send-email-thierry.reding@avionic-design.de> In-Reply-To: <1339427118-32263-9-git-send-email-thierry.reding@avionic-design.de> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-pci-owner@vger.kernel.org List-ID: On 06/11/2012 09:05 AM, Thierry Reding wrote: > Device tree support for the TPS6586x PMU used on Harmony has recently > been added. This commit adds the required device tree nodes to probe the > PMU from the device tree. > diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts > + tps6586x@34 { > + compatible = "ti,tps6586x"; > + reg = <0x34>; > + interrupts = <0 88 0x4>; > + > + #gpio-cells = <2>; > + gpio-controller; > + > + regulators { Per the TPS65911 discussion on regulator bindings, this node should have: #address-cells = <1>; #size-cells = <0>; > + sm0 { Each of these nodes should be named regulator@0, regulator@1, etc. Within each of these nodes, you need a matching reg property. reg = <0>; and something to identify which regulator within the chip this node configurations, although I don't think we've reached a final decision on the property name. See the the following for details: http://www.spinics.net/lists/linux-tegra/msg05577.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Mon, 11 Jun 2012 15:36:56 -0600 Subject: [PATCH v2 08/10] ARM: tegra: harmony: Initialize regulators from DT In-Reply-To: <1339427118-32263-9-git-send-email-thierry.reding@avionic-design.de> References: <1339427118-32263-1-git-send-email-thierry.reding@avionic-design.de> <1339427118-32263-9-git-send-email-thierry.reding@avionic-design.de> Message-ID: <4FD664F8.4030800@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06/11/2012 09:05 AM, Thierry Reding wrote: > Device tree support for the TPS6586x PMU used on Harmony has recently > been added. This commit adds the required device tree nodes to probe the > PMU from the device tree. > diff --git a/arch/arm/boot/dts/tegra-harmony.dts b/arch/arm/boot/dts/tegra-harmony.dts > + tps6586x at 34 { > + compatible = "ti,tps6586x"; > + reg = <0x34>; > + interrupts = <0 88 0x4>; > + > + #gpio-cells = <2>; > + gpio-controller; > + > + regulators { Per the TPS65911 discussion on regulator bindings, this node should have: #address-cells = <1>; #size-cells = <0>; > + sm0 { Each of these nodes should be named regulator at 0, regulator at 1, etc. Within each of these nodes, you need a matching reg property. reg = <0>; and something to identify which regulator within the chip this node configurations, although I don't think we've reached a final decision on the property name. See the the following for details: http://www.spinics.net/lists/linux-tegra/msg05577.html