From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [PATCH] kvm: notify host when guest panicked Date: Tue, 12 Jun 2012 16:07:07 +0800 Message-ID: <4FD6F8AB.5060802@cn.fujitsu.com> References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FD6E5EC.3090802@cn.fujitsu.com> <4FD6F488.7090303@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm list , Avi Kivity , qemu-devel , "linux-kernel@vger.kernel.org" , "Daniel P. Berrange" , KAMEZAWA Hiroyuki , Jan Kiszka , Gleb Natapov To: Christian Borntraeger Return-path: In-Reply-To: <4FD6F488.7090303@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org At 06/12/2012 03:49 PM, Christian Borntraeger Wrote: >>> We have three solutions to implement this feature: >>> 1. use vmcall >>> 2. use I/O port >>> 3. use virtio-serial. >> >>> We have decided to avoid touching hypervisor. The reason why I choose >>> choose the I/O port is: >>> 1. it is easier to implememt >>> 2. it does not depend any virtual device >>> 3. it can work when startint the kernel > > Havent looked deeply into that, butz wouldnt kvm_hypercall0 also fulfill all of these > points? You just have to define the number for each architecture and then it should be > possible to write a simple panic driver that works on all architectures. kvm_hypercall0? Avi said that we should avoid touching hypercall. Thanks Wen Congyang > >>> --- a/include/linux/kvm_para.h >>> +++ b/include/linux/kvm_para.h >>> @@ -20,6 +20,14 @@ >>> #define KVM_HC_FEATURES 3 >>> #define KVM_HC_PPC_MAP_MAGIC_PAGE 4 >>> >>> +#define KVM_PV_PORT (0x505UL) >>> + > > ignoring the above, shouldnt a port number go into an architecture specific file? > > > Christian > > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57584) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeM4P-0000wQ-T8 for qemu-devel@nongnu.org; Tue, 12 Jun 2012 04:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeM4E-0007UE-Gu for qemu-devel@nongnu.org; Tue, 12 Jun 2012 04:03:21 -0400 Received: from [222.73.24.84] (port=38040 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeM4E-0007Qf-2I for qemu-devel@nongnu.org; Tue, 12 Jun 2012 04:03:10 -0400 Message-ID: <4FD6F8AB.5060802@cn.fujitsu.com> Date: Tue, 12 Jun 2012 16:07:07 +0800 From: Wen Congyang MIME-Version: 1.0 References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FD6E5EC.3090802@cn.fujitsu.com> <4FD6F488.7090303@de.ibm.com> In-Reply-To: <4FD6F488.7090303@de.ibm.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH] kvm: notify host when guest panicked List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Gleb Natapov , kvm list , Jan Kiszka , "linux-kernel@vger.kernel.org" , qemu-devel , Avi Kivity , KAMEZAWA Hiroyuki At 06/12/2012 03:49 PM, Christian Borntraeger Wrote: >>> We have three solutions to implement this feature: >>> 1. use vmcall >>> 2. use I/O port >>> 3. use virtio-serial. >> >>> We have decided to avoid touching hypervisor. The reason why I choose >>> choose the I/O port is: >>> 1. it is easier to implememt >>> 2. it does not depend any virtual device >>> 3. it can work when startint the kernel > > Havent looked deeply into that, butz wouldnt kvm_hypercall0 also fulfill all of these > points? You just have to define the number for each architecture and then it should be > possible to write a simple panic driver that works on all architectures. kvm_hypercall0? Avi said that we should avoid touching hypercall. Thanks Wen Congyang > >>> --- a/include/linux/kvm_para.h >>> +++ b/include/linux/kvm_para.h >>> @@ -20,6 +20,14 @@ >>> #define KVM_HC_FEATURES 3 >>> #define KVM_HC_PPC_MAP_MAGIC_PAGE 4 >>> >>> +#define KVM_PV_PORT (0x505UL) >>> + > > ignoring the above, shouldnt a port number go into an architecture specific file? > > > Christian > >