Re: iio: vcnl4000 ALS/proximity driver

[Jonathan Cameron <jic23@cam.ac.uk>]

On 6/12/2012 1:12 PM, Peter Meerwald wrote:
> Hello Jonathan,
>
>>> /sys/bus/iio/devices/iio:deviceX/out_voltageY&Z_raw
>> err. that's curious. You can't set that...  Goes to show I should review
>> changes to this file more carefully. I just shouted down adding the stuff that
>> would provide that precisely because it made no sense.
>
> I leave that to you
>
>>> in iio.h:
>>>    * @channel:		What number or name do we wish to assign the channel.
>>> what is meant by 'name' here?
>> Oops. Comment has rotted.  Drop the name bit if you fancy doing a patch.
>
> will do
>
>>> * @indexed:		Specify the channel has a numerical index. If not,
>>>    *			the value in channel will be suppressed for attribute
>>>    *			but not for event codes. Typically set it to 0 when
>>>    *			the index is false.
>>> I am not sure what an 'attribute code' is (sysfs name?)
>> attribute name  (which is just a sysfs name as you call it) Again,
>> could do with fixing.
>
> * @indexed:		Specify the channel has a numerical index. If not,
>   *			the channel index number will be suppressed for sysfs
>   *			attributes but not for event codes. Typically set it
>   *			to 0 when the index is 0.
>
>>> I am not sure what 'index is false' means
>> index  == 0; Oops, more good points. Thanks!
>
> or should it be 'Typically set it to 0 when the index is 0 and there is
> just one channel.'?
I'd just drop the typically bit entirely.... It's gibberish as you
pointed out...
>
> regards, p.
>