Re: [net-next.git 4/4 (v4)] stmmac: add the Energy Efficient Ethernet support

[Giuseppe CAVALLARO <peppe.cavallaro@st.com>]

On 6/12/2012 3:09 PM, Yuval Mintz wrote:
> Hi Giuseppe,
> 
>> @@ -1541,10 +1663,37 @@ static irqreturn_t stmmac_interrupt(int irq,
>> void *dev_id)
>> +		if (unlikely(status)) {
>> +			if (status & core_mmc_tx_irq)
>> +				priv->xstats.mmc_tx_irq_n++;
>> +			if (status & core_mmc_rx_irq)
>> +				priv->xstats.mmc_rx_irq_n++;
>> +			if (status & core_mmc_rx_csum_offload_irq)
>> +				priv->xstats.mmc_rx_csum_offload_irq_n++;
>> +			if (status & core_irq_receive_pmt_irq)
>> +				priv->xstats.irq_receive_pmt_irq_n++;
>> +
> 
> Are these EEE related?
> 
>> +	/* To handle DMA interrupts */
> 
> Is this related?
> 

To clearly manage and expose the lpi interrupt status and eee ethtool
stats I've had to do some modifications to the driver's design and I
found really useful to move other parts of the code (e.g. mmc irq stat)
in the main directly. So this just is the result of a complete reworking
made to introduce the EEE. I could better document it in the patch's
comment or create a separate patch that could take a while.

Cheers
Peppe

> 
> Cheers,
> Yuval Mintz
> 
> 
>