From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: ensure HDMI port is disabled inside set_infoframes
Date: Tue, 12 Jun 2012 12:43:42 -0300 [thread overview]
Message-ID: <4FD763AE.1040306@linux.intel.com> (raw)
In-Reply-To: <1339511805-3193-1-git-send-email-daniel.vetter@ffwll.ch>
On 06/12/2012 11:36 AM, Daniel Vetter wrote:
> This function is supposed to be used at mode set time, so prevent
> against future mistakes by adding a WARN().
>
> Based on a patch by Paulo Zanoni, with the check extracted into a
> little assert_hdmi_port_disabled helper added to make things self
> documenting and move the assert stuff out of line.
>
> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Apart from a typo in 'expectin' below:
Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
> + WARN(I915_READ(intel_hdmi->sdvox_reg) & enabled_bits,
> + "HDMI port enabled, expectin disabled\n");
^^
Eugeni
next prev parent reply other threads:[~2012-06-12 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 14:36 [PATCH] drm/i915: ensure HDMI port is disabled inside set_infoframes Daniel Vetter
2012-06-12 14:35 ` Paulo Zanoni
2012-06-12 15:53 ` Eugeni Dodonov
2012-06-12 15:43 ` Eugeni Dodonov [this message]
2012-06-12 17:21 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD763AE.1040306@linux.intel.com \
--to=eugeni.dodonov@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=eugeni.dodonov@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.