From: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
To: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] automake: revert -Werror by default
Date: Tue, 12 Jun 2012 21:22:28 +0530 [thread overview]
Message-ID: <4FD765BC.1020309@suse.com> (raw)
In-Reply-To: <1339496358-27940-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
On 06/12/2012 03:49 PM, Jeff Layton wrote:
> I think in hindsight, that adding -Werror by default was a mistake.
> cifs-utils is built in a wide range of environments and tools, and it's
> very difficult to eliminate all of the possible warnings.
>
> Let's go ahead and remove it and reduce the steady trickle of patches
> that are simply to silence obscure warnings.
>
> Cc: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
> Signed-off-by: Jeff Layton <jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
> Makefile.am | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 05729ca..b412262 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -1,4 +1,4 @@
> -AM_CFLAGS = -Wall -Wextra -Werror -D_FORTIFY_SOURCE=2
> +AM_CFLAGS = -Wall -Wextra -D_FORTIFY_SOURCE=2
> ACLOCAL_AMFLAGS = -I aclocal
>
+ 1
Sounds like the right thing to do.
Acked-by: Suresh Jayaraman <sjayaraman-IBi9RG/b67k@public.gmane.org>
next prev parent reply other threads:[~2012-06-12 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 10:19 [PATCH] automake: revert -Werror by default Jeff Layton
[not found] ` <1339496358-27940-1-git-send-email-jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
2012-06-12 15:52 ` Suresh Jayaraman [this message]
2012-06-14 15:00 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD765BC.1020309@suse.com \
--to=sjayaraman-ibi9rg/b67k@public.gmane.org \
--cc=jlayton-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
--cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.