From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: ensure HDMI port is disabled
 inside set_infoframes
Date: Tue, 12 Jun 2012 12:53:18 -0300
Message-ID: <4FD765EE.8030205@linux.intel.com>
References: <1339511805-3193-1-git-send-email-daniel.vetter@ffwll.ch>
	<CA+gsUGRaQdqwZ9yDbXT7qYSBycGPG6eZ7-Hfot1Q+SdTNNoCmQ@mail.gmail.com>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id C16139E8B1
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Jun 2012 08:51:48 -0700 (PDT)
In-Reply-To: <CA+gsUGRaQdqwZ9yDbXT7qYSBycGPG6eZ7-Hfot1Q+SdTNNoCmQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On 06/12/2012 11:35 AM, Paulo Zanoni wrote:
> My crystal ball tells me a check for IS_HASWELL_OR_NEWER would prevent
> more changes to this code in the future.

I think that a .has_ddi (or similar) flag would be better than checking
for post-Haswell variants, as not necessarily all of them could work in
the same way. But we are still far far away from having to face this
case case anyway :).

Eugeni