diff for duplicates of <4FD7943E.60302@firmworks.com> diff --git a/a/1.1.hdr b/a/1.1.hdr deleted file mode 100644 index 094af2c..0000000 --- a/a/1.1.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/plain; charset=ISO-8859-1; format=flowed -Content-Transfer-Encoding: 7bit diff --git a/a/1.2.bin b/a/1.2.bin deleted file mode 100644 index b8c1302..0000000 --- a/a/1.2.bin +++ /dev/null @@ -1,254 +0,0 @@ -<html> - <head> - <meta content="text/html; charset=ISO-8859-1" - http-equiv="Content-Type"> - </head> - <body bgcolor="#FFFFFF" text="#000000"> - <tt>On 6/12/2012 7:20 AM, Thierry Reding wrote:</tt> - <blockquote - cite="mid:20120612172041.GA28010-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org" - type="cite"> - <pre wrap=""><tt>* Stephen Warren wrote: -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>On 06/12/2012 12:21 AM, Thierry Reding wrote: -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>* Stephen Warren wrote: -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>On 06/11/2012 09:05 AM, Thierry Reding wrote: -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>This commit adds support for instantiating the Tegra PCIe -controller from a device tree. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>+++ b/Documentation/devicetree/bindings/pci/tegra-pcie.txt -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Can we please name this nvidia,tegra20-pcie.txt to match the -naming of all the other Tegra bindings. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Yes, will do. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>+Required properties: +- compatible: "nvidia,tegra20-pcie" +- -reg: physical base address and length of the controller's -registers -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Since there's more than one range now, that should specify how -many entries are required and what they represent. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Okay. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>+Optional properties: +- pex-clk-supply: supply voltage for -internal reference clock +- vdd-supply: power supply for -controller (1.05V) -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Those shouldn't be optional. If the board has no regulator, the -board's .dts should provide a fixed always-on regulator that -those properties can refer to, so that the driver can always -get() those regulators. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -That'll add more dummy regulators and I don't think sprinkling them -across the DTS is going to work very well. Maybe collecting them -under a top-level "regulators" node is a good option. If you have a -better alternative, I'm all open for it. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>diff --git a/arch/arm/boot/dts/tegra20.dtsi -b/arch/arm/boot/dts/tegra20.dtsi -</tt></pre> - </blockquote> - <pre wrap=""><tt> -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>+ pci { -</tt></pre> - </blockquote> - <pre wrap=""><tt>... -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>+ status = "disable"; -</tt></pre> - </blockquote> - <pre wrap=""><tt> -That should be "disabled"; sorry for providing a bad example. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Yes. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>diff --git a/arch/arm/mach-tegra/pcie.c -b/arch/arm/mach-tegra/pcie.c -</tt></pre> - </blockquote> - <pre wrap=""><tt> -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>+static struct tegra_pcie_pdata *tegra_pcie_parse_dt(struct -platform_device *pdev) -</tt></pre> - </blockquote> - <pre wrap=""><tt> -</tt></pre> - <blockquote type="cite"> - <pre wrap=""><tt>+ if (of_find_property(node, "vdd-supply", NULL)) { -</tt></pre> - </blockquote> - <pre wrap=""><tt> -As mentioned above, that if statement should be removed, since -the regulators shouldn't be optional. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Okay. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>+ pcie->vdd_supply = regulator_get(&pdev->dev, "vdd"); -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Those could be devm_regulator_get(). Then tegra_pcie_remove() -wouldn't have to put() them. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Okay. - -</tt></pre> - <blockquote type="cite"> - <blockquote type="cite"> - <pre wrap=""><tt>+ for (i = 0; i < TEGRA_PCIE_MAX_PORTS; i++) + -pdata->enable_ports[i] = true; -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Shouldn't the DT indicate which ports are used? I assume there's -some reason that the existing driver allows that to be -configured, rather than always enabling all ports. At least, -enumeration time wasted on non-existent ports springs to mind, -and perhaps attempting to enable port 1 when port 0 is x4 and -using all the lanes would cause errors in port 0? -</tt></pre> - </blockquote> - <pre wrap=""><tt> -Yes, that's been on my mind as well. I'm not sure about the best -binding for this. Perhaps something like: - -pci { enable-ports = <0 1 2>; }; - -Would do? -</tt></pre> - </blockquote> - <pre wrap=""><tt> -That seems reasonable, although since the property is presumably -something specific to the Tegra PCIe binding, not generic, I think it -should be nvidia,enable-ports. -</tt></pre> - </blockquote> - <pre wrap=""><tt> -I came up with the following alternative: - - pci { - compatible = "nvidia,tegra20-pcie"; - reg = <0x80003000 0x00000800 /* PADS registers */ - 0x80003800 0x00000200 /* AFI registers */ - 0x80004000 0x00100000 /* configuration space */ - 0x80104000 0x00100000 /* extended configuration space */ - 0x80400000 0x00010000 /* downstream I/O */ - 0x90000000 0x10000000 /* non-prefetchable memory */ - 0xa0000000 0x10000000>; /* prefetchable memory */ - interrupts = <0 98 0x04 /* controller interrupt */ - 0 99 0x04>; /* MSI interrupt */ - status = "disabled"; - - ranges = <0x80000000 0x80000000 0x00002000 /* 2 root ports */ - 0x80004000 0x80004000 0x00100000 /* configuration space */ - 0x80104000 0x80104000 0x00100000 /* extended configuration space */ - 0x80400000 0x80400000 0x00010000 /* downstream I/O */ - 0x90000000 0x90000000 0x10000000 /* non-prefetchable memory */ - 0xa0000000 0xa0000000 0x10000000>; /* prefetchable memory */ - - #address-cells = <1>; - #size-cells = <1>; - - port@80000000 { - reg = <0x80000000 0x00001000>; - status = "disabled"; - }; - - port@80001000 { - reg = <0x80001000 0x00001000>; - status = "disabled"; - }; - }; - -The "ranges" property can probably be cleaned up a bit, but the most -interesting part is the port@ children, which can simply be enabled in board -DTS files by setting the status property to "okay". I find that somewhat more -intuitive to the variant with an "enable-ports" property. - -What do you think of this?</tt></pre> - </blockquote> - <br> - The problem is that children of a PCI-ish bus have specific - expectations about the parent address format - the standard - 3-address-cell PCI addressing. So making a PCI bus node - even if - it is PCIe - with 1 address cell is a problem.<br> - <br> - Also, if a given address range is listed in "reg", it should not - also be listed in "ranges". A block of addresses is either - "claimed" by the parent node (reg property) or passed through to its - children (ranges property), but not both. "reg" entries are - appropriate for entities that pertain to the overall control of the - bus interface itself, while "ranges" entries are for chunks of - address space that are overlaid onto child devices.<br> - <br> - <blockquote - cite="mid:20120612172041.GA28010-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org" - type="cite"> - <pre wrap=""><tt> - -Thierry -</tt></pre> - <tt><br> - </tt> - <fieldset class="mimeAttachmentHeader"></fieldset> - <tt><br> - </tt> - <pre wrap=""><tt>_______________________________________________ -devicetree-discuss mailing list -<a class="moz-txt-link-abbreviated" href="mailto:devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org">devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org</a> -<a class="moz-txt-link-freetext" href="https://lists.ozlabs.org/listinfo/devicetree-discuss">https://lists.ozlabs.org/listinfo/devicetree-discuss</a> -</tt></pre> - </blockquote> - </body> -</html> diff --git a/a/1.2.hdr b/a/1.2.hdr deleted file mode 100644 index e403a18..0000000 --- a/a/1.2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/html; charset=ISO-8859-1 -Content-Transfer-Encoding: 7bit diff --git a/a/1.1.txt b/N1/1.txt similarity index 95% rename from a/1.1.txt rename to N1/1.txt index a2c9164..bab5f7a 100644 --- a/a/1.1.txt +++ b/N1/1.txt @@ -113,12 +113,12 @@ On 6/12/2012 7:20 AM, Thierry Reding wrote: > #address-cells =<1>; > #size-cells =<1>; > -> port@80000000 { +> port at 80000000 { > reg =<0x80000000 0x00001000>; > status = "disabled"; > }; > -> port@80001000 { +> port at 80001000 { > reg =<0x80001000 0x00001000>; > status = "disabled"; > }; @@ -151,5 +151,8 @@ child devices. > > _______________________________________________ > devicetree-discuss mailing list -> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org +> devicetree-discuss at lists.ozlabs.org > https://lists.ozlabs.org/listinfo/devicetree-discuss +-------------- next part -------------- +An HTML attachment was scrubbed... +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120612/f97d2ef4/attachment-0001.html> diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 4b86001..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,4 +0,0 @@ -Content-Type: text/plain; charset="us-ascii" -MIME-Version: 1.0 -Content-Transfer-Encoding: 7bit -Content-Disposition: inline diff --git a/a/2.txt b/a/2.txt deleted file mode 100644 index 0fd860f..0000000 --- a/a/2.txt +++ /dev/null @@ -1,4 +0,0 @@ -_______________________________________________ -devicetree-discuss mailing list -devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org -https://lists.ozlabs.org/listinfo/devicetree-discuss diff --git a/a/content_digest b/N1/content_digest index 1aa0fe1..f089bd2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,20 +4,11 @@ "ref\020120612062124.GE4040@avionic-0098.adnet.avionic-design.de\0" "ref\04FD763C5.3090500@wwwdotorg.org\0" "ref\020120612172041.GA28010@avionic-0098.adnet.avionic-design.de\0" - "ref\020120612172041.GA28010-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org\0" - "From\0Mitch Bradley <wmb-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>\0" - "Subject\0Re: [PATCH v2 07/10] ARM: tegra: pcie: Add device tree support\0" + "From\0wmb@firmworks.com (Mitch Bradley)\0" + "Subject\0[PATCH v2 07/10] ARM: tegra: pcie: Add device tree support\0" "Date\0Tue, 12 Jun 2012 09:10:54 -1000\0" - "To\0Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>\0" - "Cc\0Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>" - linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org - Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> - Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org> - Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org> - linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org\0" - "\02:1.1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On 6/12/2012 7:20 AM, Thierry Reding wrote:\n" "> * Stephen Warren wrote:\n" @@ -134,12 +125,12 @@ "> \t\t#address-cells =<1>;\n" "> \t\t#size-cells =<1>;\n" ">\n" - "> \t\tport@80000000 {\n" + "> \t\tport at 80000000 {\n" "> \t\t\treg =<0x80000000 0x00001000>;\n" "> \t\t\tstatus = \"disabled\";\n" "> \t\t};\n" ">\n" - "> \t\tport@80001000 {\n" + "> \t\tport at 80001000 {\n" "> \t\t\treg =<0x80001000 0x00001000>;\n" "> \t\t\tstatus = \"disabled\";\n" "> \t\t};\n" @@ -172,269 +163,10 @@ ">\n" "> _______________________________________________\n" "> devicetree-discuss mailing list\n" - "> devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org\n" - > https://lists.ozlabs.org/listinfo/devicetree-discuss - "\02:1.2\0" - "b\0" - "<html>\n" - " <head>\n" - " <meta content=\"text/html; charset=ISO-8859-1\"\n" - " http-equiv=\"Content-Type\">\n" - " </head>\n" - " <body bgcolor=\"#FFFFFF\" text=\"#000000\">\n" - " <tt>On 6/12/2012 7:20 AM, Thierry Reding wrote:</tt>\n" - " <blockquote\n" - " cite=\"mid:20120612172041.GA28010-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org\"\n" - " type=\"cite\">\n" - " <pre wrap=\"\"><tt>* Stephen Warren wrote:\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>On 06/12/2012 12:21 AM, Thierry Reding wrote:\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>* Stephen Warren wrote:\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>On 06/11/2012 09:05 AM, Thierry Reding wrote:\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>This commit adds support for instantiating the Tegra PCIe\n" - "controller from a device tree.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+++ b/Documentation/devicetree/bindings/pci/tegra-pcie.txt\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Can we please name this nvidia,tegra20-pcie.txt to match the\n" - "naming of all the other Tegra bindings.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Yes, will do.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+Required properties: +- compatible: \"nvidia,tegra20-pcie\" +-\n" - "reg: physical base address and length of the controller's\n" - "registers\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Since there's more than one range now, that should specify how\n" - "many entries are required and what they represent.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Okay.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+Optional properties: +- pex-clk-supply: supply voltage for\n" - "internal reference clock +- vdd-supply: power supply for\n" - "controller (1.05V)\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Those shouldn't be optional. If the board has no regulator, the\n" - "board's .dts should provide a fixed always-on regulator that\n" - "those properties can refer to, so that the driver can always\n" - "get() those regulators.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "That'll add more dummy regulators and I don't think sprinkling them\n" - "across the DTS is going to work very well. Maybe collecting them\n" - "under a top-level \"regulators\" node is a good option. If you have a\n" - "better alternative, I'm all open for it.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>diff --git a/arch/arm/boot/dts/tegra20.dtsi\n" - "b/arch/arm/boot/dts/tegra20.dtsi\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+\tpci {\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>...\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+\t\tstatus = \"disable\";\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "That should be \"disabled\"; sorry for providing a bad example.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Yes.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>diff --git a/arch/arm/mach-tegra/pcie.c\n" - "b/arch/arm/mach-tegra/pcie.c\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+static struct tegra_pcie_pdata *tegra_pcie_parse_dt(struct\n" - "platform_device *pdev)\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+\tif (of_find_property(node, \"vdd-supply\", NULL)) {\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "As mentioned above, that if statement should be removed, since\n" - "the regulators shouldn't be optional.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Okay.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+\t\tpcie->vdd_supply = regulator_get(&pdev->dev, \"vdd\");\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Those could be devm_regulator_get(). Then tegra_pcie_remove()\n" - "wouldn't have to put() them.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Okay.\n" - "\n" - "</tt></pre>\n" - " <blockquote type=\"cite\">\n" - " <blockquote type=\"cite\">\n" - " <pre wrap=\"\"><tt>+\tfor (i = 0; i < TEGRA_PCIE_MAX_PORTS; i++) +\n" - "pdata->enable_ports[i] = true;\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Shouldn't the DT indicate which ports are used? I assume there's\n" - "some reason that the existing driver allows that to be\n" - "configured, rather than always enabling all ports. At least,\n" - "enumeration time wasted on non-existent ports springs to mind,\n" - "and perhaps attempting to enable port 1 when port 0 is x4 and\n" - "using all the lanes would cause errors in port 0?\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "Yes, that's been on my mind as well. I'm not sure about the best\n" - "binding for this. Perhaps something like:\n" - "\n" - "pci { enable-ports = <0 1 2>; };\n" - "\n" - "Would do?\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "That seems reasonable, although since the property is presumably\n" - "something specific to the Tegra PCIe binding, not generic, I think it\n" - "should be nvidia,enable-ports.\n" - "</tt></pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><tt>\n" - "I came up with the following alternative:\n" - "\n" - "\tpci {\n" - "\t\tcompatible = \"nvidia,tegra20-pcie\";\n" - "\t\treg = <0x80003000 0x00000800 /* PADS registers */\n" - "\t\t 0x80003800 0x00000200 /* AFI registers */\n" - "\t\t 0x80004000 0x00100000 /* configuration space */\n" - "\t\t 0x80104000 0x00100000 /* extended configuration space */\n" - "\t\t 0x80400000 0x00010000 /* downstream I/O */\n" - "\t\t 0x90000000 0x10000000 /* non-prefetchable memory */\n" - "\t\t 0xa0000000 0x10000000>; /* prefetchable memory */\n" - "\t\tinterrupts = <0 98 0x04 /* controller interrupt */\n" - "\t\t 0 99 0x04>; /* MSI interrupt */\n" - "\t\tstatus = \"disabled\";\n" - "\n" - "\t\tranges = <0x80000000 0x80000000 0x00002000 /* 2 root ports */\n" - "\t\t\t 0x80004000 0x80004000 0x00100000 /* configuration space */\n" - "\t\t\t 0x80104000 0x80104000 0x00100000 /* extended configuration space */\n" - "\t\t\t 0x80400000 0x80400000 0x00010000 /* downstream I/O */\n" - "\t\t\t 0x90000000 0x90000000 0x10000000 /* non-prefetchable memory */\n" - "\t\t\t 0xa0000000 0xa0000000 0x10000000>; /* prefetchable memory */\n" - "\n" - "\t\t#address-cells = <1>;\n" - "\t\t#size-cells = <1>;\n" - "\n" - "\t\tport@80000000 {\n" - "\t\t\treg = <0x80000000 0x00001000>;\n" - "\t\t\tstatus = \"disabled\";\n" - "\t\t};\n" - "\n" - "\t\tport@80001000 {\n" - "\t\t\treg = <0x80001000 0x00001000>;\n" - "\t\t\tstatus = \"disabled\";\n" - "\t\t};\n" - "\t};\n" - "\n" - "The \"ranges\" property can probably be cleaned up a bit, but the most\n" - "interesting part is the port@ children, which can simply be enabled in board\n" - "DTS files by setting the status property to \"okay\". I find that somewhat more\n" - "intuitive to the variant with an \"enable-ports\" property.\n" - "\n" - "What do you think of this?</tt></pre>\n" - " </blockquote>\n" - " <br>\n" - " The problem is that children of a PCI-ish bus have specific\n" - " expectations about the parent address format - the standard\n" - " 3-address-cell PCI addressing. So making a PCI bus node - even if\n" - " it is PCIe - with 1 address cell is a problem.<br>\n" - " <br>\n" - " Also, if a given address range is listed in \"reg\", it should not\n" - " also be listed in \"ranges\". A block of addresses is either\n" - " \"claimed\" by the parent node (reg property) or passed through to its\n" - " children (ranges property), but not both. \"reg\" entries are\n" - " appropriate for entities that pertain to the overall control of the\n" - " bus interface itself, while \"ranges\" entries are for chunks of\n" - " address space that are overlaid onto child devices.<br>\n" - " <br>\n" - " <blockquote\n" - " cite=\"mid:20120612172041.GA28010-RM9K5IK7kjIyiCvfTdI0JKcOhU4Rzj621B7CTYaBSLdn68oJJulU0Q@public.gmane.org\"\n" - " type=\"cite\">\n" - " <pre wrap=\"\"><tt>\n" - "\n" - "Thierry\n" - "</tt></pre>\n" - " <tt><br>\n" - " </tt>\n" - " <fieldset class=\"mimeAttachmentHeader\"></fieldset>\n" - " <tt><br>\n" - " </tt>\n" - " <pre wrap=\"\"><tt>_______________________________________________\n" - "devicetree-discuss mailing list\n" - "<a class=\"moz-txt-link-abbreviated\" href=\"mailto:devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org\">devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org</a>\n" - "<a class=\"moz-txt-link-freetext\" href=\"https://lists.ozlabs.org/listinfo/devicetree-discuss\">https://lists.ozlabs.org/listinfo/devicetree-discuss</a>\n" - "</tt></pre>\n" - " </blockquote>\n" - " </body>\n" - "</html>\n" - "\01:2\0" - "b\0" - "_______________________________________________\n" - "devicetree-discuss mailing list\n" - "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org\n" - https://lists.ozlabs.org/listinfo/devicetree-discuss + "> devicetree-discuss at lists.ozlabs.org\n" + "> https://lists.ozlabs.org/listinfo/devicetree-discuss\n" + "-------------- next part --------------\n" + "An HTML attachment was scrubbed...\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120612/f97d2ef4/attachment-0001.html> -6404e78a7ff471baa89f443af858789fd28addfc722f95f0add49fc59bdaad13 +4bc035aedf9270be1fe4c8b1ede946d48905723e9a6f59478ec77b3789f2b2e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.