From: Marek Marczykowski <marmarek@invisiblethingslab.com>
To: Kouya Shimura <kouya@jp.fujitsu.com>
Cc: Zhigang Wang <zhigang.x.wang@oracle.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/hotplug: fix locking
Date: Wed, 13 Jun 2012 04:25:54 +0200 [thread overview]
Message-ID: <4FD7FA32.2010006@invisiblethingslab.com> (raw)
In-Reply-To: <87hauhvx5x.fsf@jp.fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 1028 bytes --]
On 12.06.2012 08:53, Kouya Shimura wrote:
> Hi,
>
> The owner support is introduced in c/s 8175, not by me.
> Anyway, something is wrong with your execution trace.
>
>> + '[' 6 -gt 5 ']'
>> + sleep 1
> <<< Why claim_lock() returns here???
>> + do_or_die losetup -r /dev/loop27 /OVS/Repositories/0004fb00000300000aac184a9bbab7a9/VirtualDisks/0004fb00001200002b0ef651033c8381.img
>> + losetup -r /dev/loop27 /OVS/Repositories/0004fb00000300000aac184a9bbab7a9/Vi
>
> I don't know what is a problem and whether your patch resolves the issue or not.
I can confirm this problem, I've faced it some time ago:
http://lists.xen.org/archives/html/xen-devel/2011-07/msg00182.html
> It would be better to replace locking.sh with the RHEL5 implementation
> which uses 'flock' rather than to fix it.
I agree. Currently I've workarounded it by adding flock in udev rule which run
this script, but working locking.sh will be much nicer.
--
Best Regards / Pozdrawiam,
Marek Marczykowski
Invisible Things Lab
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 554 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2012-06-13 2:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 13:59 [PATCH] tools/hotplug: fix locking Zhigang Wang
2012-06-12 6:53 ` Kouya Shimura
2012-06-13 2:25 ` Marek Marczykowski [this message]
2012-06-13 8:11 ` Ian Campbell
2012-06-13 8:16 ` Zhigang Wang
-- strict thread matches above, loose matches on Subject: below --
2012-06-13 17:29 Zhigang Wang
2012-06-20 15:34 ` Ian Campbell
2012-06-20 17:53 ` Zhigang Wang
2012-06-21 11:42 ` Ian Campbell
2012-06-21 11:49 ` Ian Campbell
2012-06-21 12:08 ` Zhigang Wang
2012-06-21 12:23 ` Daniel P. Berrange
2012-06-21 13:07 ` Zhigang Wang
2012-06-21 12:20 ` Daniel P. Berrange
2012-06-26 15:53 ` Ian Campbell
2012-06-26 16:14 ` Daniel P. Berrange
2012-07-04 14:48 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD7FA32.2010006@invisiblethingslab.com \
--to=marmarek@invisiblethingslab.com \
--cc=kouya@jp.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=zhigang.x.wang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.