From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [PATCH 3/3] deal with guest panicked event Date: Wed, 13 Jun 2012 15:02:56 +0800 Message-ID: <4FD83B20.9060203@cn.fujitsu.com> References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com> <4FD74447.2090906@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm list , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , "Daniel P. Berrange" , KAMEZAWA Hiroyuki , Jan Kiszka , Gleb Natapov To: Paolo Bonzini Return-path: In-Reply-To: <4FD74447.2090906@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org At 06/12/2012 09:29 PM, Paolo Bonzini Wrote: > Il 21/05/2012 08:50, Wen Congyang ha scritto: >> +DEF("onpanic", HAS_ARG, QEMU_OPTION_onpanic, \ >> + "-onpanic report|pause|quit\n" \ >> + " action when the guest is panicked [default=report]", >> + QEMU_ARCH_ALL) >> +STEXI >> +@item -onpanic @var{action} >> + >> +The @var{action} controls what QEmu will do when the guest is panicked. >> +The default is @code{report} (emit QEVENT_GUEST_PANICKED only). > > -watchdog-action just calls this "none". Yes, I will change the action name. > >> +Other possible actions are: >> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). > > Rather than just "quit", there should be choices for "shutdown", > "poweroff" and "reset" for consistency with -watchdog-action. Hmm, quit means poweroff. I will add reset, but I think we donot need shutdown, because we cannot shutdown the system when it is panicked. > > Also, this option should also be accessible from "-machine", please. I don't understand this. Do you mean we can also specify this action in -machine option? Thanks Wen Congyang > > Paolo > >> +ETEXI >> + >> HXCOMM This is the last statement. Insert new options before this line! >> STEXI >> @end table > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeiAe-00076u-2k for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:39:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeiAb-0000o9-F2 for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:39:15 -0400 Received: from [222.73.24.84] (port=22600 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeiAb-0000nG-0Y for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:39:13 -0400 Message-ID: <4FD83B20.9060203@cn.fujitsu.com> Date: Wed, 13 Jun 2012 15:02:56 +0800 From: Wen Congyang MIME-Version: 1.0 References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com> <4FD74447.2090906@redhat.com> In-Reply-To: <4FD74447.2090906@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gleb Natapov , kvm list , Jan Kiszka , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , KAMEZAWA Hiroyuki At 06/12/2012 09:29 PM, Paolo Bonzini Wrote: > Il 21/05/2012 08:50, Wen Congyang ha scritto: >> +DEF("onpanic", HAS_ARG, QEMU_OPTION_onpanic, \ >> + "-onpanic report|pause|quit\n" \ >> + " action when the guest is panicked [default=report]", >> + QEMU_ARCH_ALL) >> +STEXI >> +@item -onpanic @var{action} >> + >> +The @var{action} controls what QEmu will do when the guest is panicked. >> +The default is @code{report} (emit QEVENT_GUEST_PANICKED only). > > -watchdog-action just calls this "none". Yes, I will change the action name. > >> +Other possible actions are: >> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). > > Rather than just "quit", there should be choices for "shutdown", > "poweroff" and "reset" for consistency with -watchdog-action. Hmm, quit means poweroff. I will add reset, but I think we donot need shutdown, because we cannot shutdown the system when it is panicked. > > Also, this option should also be accessible from "-machine", please. I don't understand this. Do you mean we can also specify this action in -machine option? Thanks Wen Congyang > > Paolo > >> +ETEXI >> + >> HXCOMM This is the last statement. Insert new options before this line! >> STEXI >> @end table > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >