From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, bhutchings@solarflare.com,
rayagond@vayavyalabs.com, davem@davemloft.net,
yuvalmin@broadcom.com
Subject: Re: [net-next.git 2/4 (v2)] stmmac: do not use strict_strtoul but kstrtoul
Date: Wed, 13 Jun 2012 09:41:34 +0200 [thread overview]
Message-ID: <4FD8442E.5000601@st.com> (raw)
In-Reply-To: <1339572727.22704.314.camel@edumazet-glaptop>
On 6/13/2012 9:32 AM, Eric Dumazet wrote:
> On Wed, 2012-06-13 at 09:17 +0200, Giuseppe CAVALLARO wrote:
>> This patch replaces the obsolete strict_strtoul with kstrtoul.
>>
>> v2: also removed casting on kstrtoul.
>>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>> ---
>> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +-
>> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 67 +++++++++-----------
>> 2 files changed, 31 insertions(+), 38 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> index 6d07ba2..1d70f64 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
>> @@ -88,7 +88,7 @@ struct stmmac_priv {
>> int synopsys_id;
>> };
>>
>> -extern int phyaddr;
>> +extern unsigned long int phyaddr;
>>
>> extern int stmmac_mdio_unregister(struct net_device *ndev);
>> extern int stmmac_mdio_register(struct net_device *ndev);
>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> index 8899e10..bd53003 100644
>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
>> @@ -80,39 +80,39 @@
>>
>> /* Module parameters */
>> #define TX_TIMEO 5000 /* default 5 seconds */
>> -static int watchdog = TX_TIMEO;
>> -module_param(watchdog, int, S_IRUGO | S_IWUSR);
>> +static unsigned long int watchdog = TX_TIMEO;
>> +module_param(watchdog, ulong, S_IRUGO | S_IWUSR);
>> MODULE_PARM_DESC(watchdog, "Transmit timeout in milliseconds");
>>
>
> It seems you missed the kstrtouint() / kstrtoint() functions....
yes i did, I'll resend it again.
thanks a lot
peppe
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2012-06-13 7:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 7:17 [net-next.git 0/4] EEE for PAL and stmmac (v2) Giuseppe CAVALLARO
2012-06-13 7:17 ` [net-next.git 1/4 (v5)] phy: add the EEE support and the way to access to the MMD registers Giuseppe CAVALLARO
2012-06-13 7:17 ` [net-next.git 2/4 (v2)] stmmac: do not use strict_strtoul but kstrtoul Giuseppe CAVALLARO
2012-06-13 7:32 ` Eric Dumazet
2012-06-13 7:41 ` Giuseppe CAVALLARO [this message]
2012-06-13 7:17 ` [net-next.git 3/4] stmmac: update the driver Documentation and add EEE Giuseppe CAVALLARO
2012-06-13 7:17 ` [net-next.git 4/4 (v5)] stmmac: add the Energy Efficient Ethernet support Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD8442E.5000601@st.com \
--to=peppe.cavallaro@st.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rayagond@vayavyalabs.com \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.