From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [PATCH 3/3] deal with guest panicked event Date: Wed, 13 Jun 2012 16:00:15 +0800 Message-ID: <4FD8488F.6040707@cn.fujitsu.com> References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com> <4FD74447.2090906@redhat.com> <4FD83B20.9060203@cn.fujitsu.com> <4FD8470B.8010507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm list , Jan Kiszka , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , KAMEZAWA Hiroyuki To: Paolo Bonzini Return-path: In-Reply-To: <4FD8470B.8010507@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org At 06/13/2012 03:53 PM, Paolo Bonzini Wrote: > Il 13/06/2012 09:02, Wen Congyang ha scritto: >>>>>> +Other possible actions are: >>>>>> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >>>>>> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). >>>> >>>> Rather than just "quit", there should be choices for "shutdown", >>>> "poweroff" and "reset" for consistency with -watchdog-action. >> Hmm, quit means poweroff. I will add reset, but I think we donot >> need shutdown, because we cannot shutdown the system when it is >> panicked. > > Right. :) > > Can you also rename quit to poweroff? OK. Thanks Wen Congyang > >>>> Also, this option should also be accessible from "-machine", please. >> I don't understand this. Do you mean we can also specify this action >> in -machine option? > > Yes, like -machine panic_action=poweroff. > > Paolo > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003Ab2FMH4W (ORCPT ); Wed, 13 Jun 2012 03:56:22 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:53459 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751643Ab2FMH4U (ORCPT ); Wed, 13 Jun 2012 03:56:20 -0400 X-IronPort-AV: E=Sophos;i="4.77,402,1336320000"; d="scan'208";a="5177420" Message-ID: <4FD8488F.6040707@cn.fujitsu.com> Date: Wed, 13 Jun 2012 16:00:15 +0800 From: Wen Congyang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 MIME-Version: 1.0 To: Paolo Bonzini CC: kvm list , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , "Daniel P. Berrange" , KAMEZAWA Hiroyuki , Jan Kiszka , Gleb Natapov Subject: Re: [PATCH 3/3] deal with guest panicked event References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com> <4FD74447.2090906@redhat.com> <4FD83B20.9060203@cn.fujitsu.com> <4FD8470B.8010507@redhat.com> In-Reply-To: <4FD8470B.8010507@redhat.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/06/13 15:56:42, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/06/13 15:56:50, Serialize complete at 2012/06/13 15:56:50 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At 06/13/2012 03:53 PM, Paolo Bonzini Wrote: > Il 13/06/2012 09:02, Wen Congyang ha scritto: >>>>>> +Other possible actions are: >>>>>> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >>>>>> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). >>>> >>>> Rather than just "quit", there should be choices for "shutdown", >>>> "poweroff" and "reset" for consistency with -watchdog-action. >> Hmm, quit means poweroff. I will add reset, but I think we donot >> need shutdown, because we cannot shutdown the system when it is >> panicked. > > Right. :) > > Can you also rename quit to poweroff? OK. Thanks Wen Congyang > >>>> Also, this option should also be accessible from "-machine", please. >> I don't understand this. Do you mean we can also specify this action >> in -machine option? > > Yes, like -machine panic_action=poweroff. > > Paolo > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeiRG-0002O4-Ru for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:56:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeiRA-0004w3-BI for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:56:26 -0400 Received: from [222.73.24.84] (port=28031 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeiR9-0004vi-T9 for qemu-devel@nongnu.org; Wed, 13 Jun 2012 03:56:20 -0400 Message-ID: <4FD8488F.6040707@cn.fujitsu.com> Date: Wed, 13 Jun 2012 16:00:15 +0800 From: Wen Congyang MIME-Version: 1.0 References: <4FB9E4CE.8060709@cn.fujitsu.com> <4FB9E5CB.2020208@cn.fujitsu.com> <4FD74447.2090906@redhat.com> <4FD83B20.9060203@cn.fujitsu.com> <4FD8470B.8010507@redhat.com> In-Reply-To: <4FD8470B.8010507@redhat.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 3/3] deal with guest panicked event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Gleb Natapov , kvm list , Jan Kiszka , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , KAMEZAWA Hiroyuki At 06/13/2012 03:53 PM, Paolo Bonzini Wrote: > Il 13/06/2012 09:02, Wen Congyang ha scritto: >>>>>> +Other possible actions are: >>>>>> +@code{pause} (emit QEVENT_GUEST_PANICKED and pause VM), >>>>>> +@code{quit} (emit QEVENT_GUEST_PANICKED and quit VM). >>>> >>>> Rather than just "quit", there should be choices for "shutdown", >>>> "poweroff" and "reset" for consistency with -watchdog-action. >> Hmm, quit means poweroff. I will add reset, but I think we donot >> need shutdown, because we cannot shutdown the system when it is >> panicked. > > Right. :) > > Can you also rename quit to poweroff? OK. Thanks Wen Congyang > >>>> Also, this option should also be accessible from "-machine", please. >> I don't understand this. Do you mean we can also specify this action >> in -machine option? > > Yes, like -machine panic_action=poweroff. > > Paolo >