From: Stefan Behrens <sbehrens@giantdisaster.de>
To: Josef Bacik <josef@redhat.com>,
linux-btrfs@vger.kernel.org, David Sterba <dave@jikos.cz>
Subject: Re: [PATCH 1/2] Btrfs: use rcu to protect device->name V2
Date: Wed, 13 Jun 2012 12:47:21 +0200 [thread overview]
Message-ID: <4FD86FB9.3070503@giantdisaster.de> (raw)
In-Reply-To: <20120612223526.GJ32402@twin.jikos.cz>
On Wed, 13 Jun 2012 00:35:26 +0200, David Sterba wrote:
> On Tue, Jun 12, 2012 at 03:50:41PM -0400, Josef Bacik wrote:
>> +++ b/fs/btrfs/check-integrity.c
>> @@ -93,6 +93,7 @@
>> #include "print-tree.h"
>> #include "locking.h"
>> #include "check-integrity.h"
>> +#include "rcu-string.h"
>>
>> #define BTRFSIC_BLOCK_HASHTABLE_SIZE 0x10000
>> #define BTRFSIC_BLOCK_LINK_HASHTABLE_SIZE 0x10000
>> @@ -843,13 +844,14 @@ static int btrfsic_process_superblock_dev_mirror(
>> superblock_tmp->never_written = 0;
>> superblock_tmp->mirror_num = 1 + superblock_mirror_num;
>> if (state->print_mask & BTRFSIC_PRINT_MASK_SUPERBLOCK_WRITE)
>> - printk(KERN_INFO "New initial S-block (bdev %p, %s)"
>> - " @%llu (%s/%llu/%d)\n",
>> - superblock_bdev, device->name,
>> - (unsigned long long)dev_bytenr,
>> - dev_state->name,
>> - (unsigned long long)dev_bytenr,
>> - superblock_mirror_num);
>> + printk_in_rcu(KERN_INFO "New initial S-block (bdev %p,"
>
> can you please add the 'btrfs: ' prefixes?
Please no additional "btrfs" prefix in the check-integrity printk lines
that are enabled with the print_mask option. If they are enabled, then
for btrfs debugging, and then the context is known. And you get
thousands of these lines...
>
>> + " %s) @%llu (%s/%llu/%d)\n",
>> + superblock_bdev,
>> + rcu_str_deref(device->name),
>> + (unsigned long long)dev_bytenr,
>> + dev_state->name,
>> + (unsigned long long)dev_bytenr,
>> + superblock_mirror_num);
>> list_add(&superblock_tmp->all_blocks_node,
>> &state->all_blocks_list);
>> btrfsic_block_hashtable_add(superblock_tmp,
next prev parent reply other threads:[~2012-06-13 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 19:50 [PATCH 1/2] Btrfs: use rcu to protect device->name V2 Josef Bacik
2012-06-12 19:50 ` [PATCH 2/2] Btrfs: implement ->show_devname V2 Josef Bacik
2012-06-14 3:10 ` Miao Xie
2012-06-12 22:35 ` [PATCH 1/2] Btrfs: use rcu to protect device->name V2 David Sterba
2012-06-13 10:47 ` Stefan Behrens [this message]
2012-06-13 13:14 ` Josef Bacik
2012-06-13 13:49 ` Stefan Behrens
2012-06-13 13:51 ` Josef Bacik
2012-06-14 10:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD86FB9.3070503@giantdisaster.de \
--to=sbehrens@giantdisaster.de \
--cc=dave@jikos.cz \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.