From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sem3q-0000HH-K8 for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:48:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sem3j-00074k-FW for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:48:30 -0400 Received: from thoth.sbs.de ([192.35.17.2]:25853) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sem3j-00074I-6C for qemu-devel@nongnu.org; Wed, 13 Jun 2012 07:48:23 -0400 Message-ID: <4FD87DFE.3080904@siemens.com> Date: Wed, 13 Jun 2012 13:48:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1339513523-1699-1-git-send-email-anthony.perard@citrix.com> <1339513523-1699-6-git-send-email-anthony.perard@citrix.com> <20120612151557.GA10691@redhat.com> <4FD8764B.9060003@siemens.com> <20120613112257.GF18001@redhat.com> In-Reply-To: <20120613112257.GF18001@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Anthony PERARD , Anthony Liguori , Xen Devel , QEMU-devel , Stefano Stabellini On 2012-06-13 13:22, Michael S. Tsirkin wrote: > On Wed, Jun 13, 2012 at 01:15:23PM +0200, Jan Kiszka wrote: >> On 2012-06-12 17:15, Michael S. Tsirkin wrote: >>> On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote: >>>> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7. >>>> >>>> This function is used by a later patch to parse the BDF of the device to >>>> passthrough. >>>> >>>> Signed-off-by: Anthony PERARD >>> >>> You probably want to parse the host address? You don't want to copy the >>> bugs in pci_parse_devaddr - write your own that has sane semantics >>> for host. E.g. you need to support ARI etc. >> >> We should really consolidate over one parser for Xen, KVM device >> assignment and VFIO. It looks like they all have very similar requirements. > > Also rename pci_parse_devaddr to pci_parse_legacy_devaddr > to stress it's not something others should reuse. That depends on what pci_parse_devaddr will do in the end. If it will become as general as my qemu_parse_pci_devaddr, "legacy" would be inappropriate. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux