From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv3 RFC 0/2] kvm: direct msix injection Date: Wed, 13 Jun 2012 17:14:44 +0300 Message-ID: <4FD8A054.5080907@redhat.com> References: <20120612230703.GE1973@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Michael S. Tsirkin" , kvm@vger.kernel.org, Jan Kiszka To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:64154 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752885Ab2FMOOs (ORCPT ); Wed, 13 Jun 2012 10:14:48 -0400 In-Reply-To: <20120612230703.GE1973@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 06/13/2012 02:07 AM, Marcelo Tosatti wrote: > On Mon, Jun 11, 2012 at 02:19:17PM +0300, Michael S. Tsirkin wrote: >> We can deliver certain interrupts, notably MSIX, >> from atomic context. >> Here's an untested patch to do this (compiled only). >> >> Changes from v2: >> Don't inject broadcast interrupts directly >> Changes from v1: >> Tried to address comments from v1, except unifying >> with kvm_set_irq: passing flags to it looks too ugly. >> Added a comment. >> >> Jan, you said you can test this? > > Looks fine to me (except the unlikely). Avi/Gleb? I dislike the vcpu loop in atomic context. Some crazies keep increasing the maximum vcpu count. -- error compiling committee.c: too many arguments to function