From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Eduardo Trápani" <etrapani@gmail.com>,
git@vger.kernel.org,
"YOSHIFUJI Hideaki" <yoshfuji@linux-ipv6.org>
Subject: Re: git: Wrong parsing of ssh urls with IPv6 literals ignores port
Date: Wed, 13 Jun 2012 18:33:58 +0200 [thread overview]
Message-ID: <4FD8C0F6.8060609@lsrfire.ath.cx> (raw)
In-Reply-To: <20120612210003.GA16816@burratino>
Am 12.06.2012 23:00, schrieb Jonathan Nieder:
> Jonathan Nieder wrote:
>> René Scharfe wrote:
>
>>> How about this instead?
>>
>> Looks good to me.
>
> Oh, hold on a second. Won't this get confused by
>
> ssh://[::1]/foo/bar/baz:80/qux
>
> ?
It shouldn't, because the host part is NUL-terminated before get_port()
is called. Let's see (with the patch):
$ git clone ssh://[::1]/foo/bar/baz:80/qux
Cloning into 'qux'...
ssh: connect to host ::1 port 22: Connection refused
fatal: The remote end hung up unexpectedly
René
next prev parent reply other threads:[~2012-06-13 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111022001704.3115.87464.reportbug@hejmo>
2012-06-10 9:05 ` git: Wrong parsing of ssh urls with IPv6 literals ignores port Jonathan Nieder
2012-06-12 18:46 ` René Scharfe
2012-06-12 20:29 ` Jonathan Nieder
2012-06-12 21:00 ` Jonathan Nieder
2012-06-13 16:33 ` René Scharfe [this message]
2012-06-13 17:21 ` Junio C Hamano
2012-06-13 19:43 ` Jonathan Nieder
2012-06-13 20:10 ` Junio C Hamano
2012-06-13 20:39 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD8C0F6.8060609@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=etrapani@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.