Re: [PATCH 3/4] v4l: Unify selection targets across V4L2 and V4L2 subdev interfaces

[Sakari Ailus <sakari.ailus@iki.fi>]

Hi Sylwester,

Sylwester Nawrocki wrote:
> Hi Sakari :)
> 
> On 06/13/2012 11:11 PM, Sakari Ailus wrote:
>> Hi Sylwester,
>>
>> Thanks for the comments!!
>>
>> Sylwester Nawrocki wrote:
>>> Hi Sakari,
>>>
>>> On 06/10/2012 09:34 PM, Sakari Ailus wrote:
>>>> Signed-off-by: Sakari Ailus<sakari.ailus@iki.fi>
>>>> ---
>>>>    drivers/media/video/omap3isp/ispccdc.c    |    6 ++--
>>>>    drivers/media/video/omap3isp/isppreview.c |    6 ++--
>>>>    drivers/media/video/omap3isp/ispresizer.c |    6 ++--
>>>>    drivers/media/video/smiapp/smiapp-core.c  |   30 +++++++++---------
>>>>    drivers/media/video/v4l2-subdev.c         |    4 +-
>>>>    include/linux/v4l2-common.h               |   49
>>>> +++++++++++++++++++++++++++++
>>>>    include/linux/v4l2-subdev.h               |   13 +------
>>>>    include/linux/videodev2.h                 |   20 +----------
>>>>    8 files changed, 79 insertions(+), 55 deletions(-)
>>>>    create mode 100644 include/linux/v4l2-common.h
>>> <snip>
>>>> diff --git a/include/linux/v4l2-common.h b/include/linux/v4l2-common.h
>>>> new file mode 100644
>>>> index 0000000..e0db6e3
>>>> --- /dev/null
>>>> +++ b/include/linux/v4l2-common.h
>>>> @@ -0,0 +1,49 @@
>>>> +/*
>>>> + * include/linux/v4l2-common.h
>>>> + *
>>>> + * Common V4L2 and V4L2 subdev definitions.
>>>> + *
>>>> + * Users are adviced to #include this file either videodev2.h (V4L2)
> 
> Shouldn't be "advised" ?

Yes. Fixed.

>>>
>>> s/either videodev2.h/either from videodev2.h ?
>>>
>>>> + * or v4l2-subdev.h (V4L2 subdev) rather than to refer to this file
>>>
>>> s/or v4l2-subdev.h/or from v4l2-subdev.h ?
>>
>> How about "through" for both?
> 
> Yeah, probably more appropriate.
> 
> [...]
>>>
>>> There are now some missing renames, due to some patches that were merged
>>> recently. Please feel free to squash the attached patch with this one.
>>
>> I merged it to the patch and put your SoB line there. :-)
> 
> OK, good :)
> 
> In case you wanted to compile test those changes, I've attached
> kernel config file for exynos4.

Compile testing? What is that? :-)

I'll check that before sending the pull req.

Cheers,

-- 
Sakari Ailus
sakari.ailus@iki.fi