From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1SewGr-0001Dv-UO for mharc-grub-devel@gnu.org; Wed, 13 Jun 2012 18:42:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SewGp-0001Ct-7X for grub-devel@gnu.org; Wed, 13 Jun 2012 18:42:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SewGn-00083L-2n for grub-devel@gnu.org; Wed, 13 Jun 2012 18:42:34 -0400 Received: from qmta12.westchester.pa.mail.comcast.net ([76.96.59.227]:52642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SewGm-00082h-VF for grub-devel@gnu.org; Wed, 13 Jun 2012 18:42:32 -0400 Received: from omta21.westchester.pa.mail.comcast.net ([76.96.62.72]) by qmta12.westchester.pa.mail.comcast.net with comcast id MyPD1j0011ZXKqc5CyiW4N; Wed, 13 Jun 2012 22:42:30 +0000 Received: from [192.168.1.101] ([24.63.69.222]) by omta21.westchester.pa.mail.comcast.net with comcast id MyiW1j00V4nkFao3hyiX7x; Wed, 13 Jun 2012 22:42:31 +0000 Message-ID: <4FD91756.9080200@comcast.net> Date: Wed, 13 Jun 2012 18:42:30 -0400 From: Robert Mabee User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] '.' causes wildcard expansion References: <4FD59694.3080600@comcast.net> In-Reply-To: <4FD59694.3080600@comcast.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 76.96.59.227 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2012 22:42:36 -0000 Having second thoughts. Where I suggested taking out this call > - else if (isregexop (ch)) > + else if (ch == '*') /* only wildcard currently implemented */ I should have just taken the extraneous '.' out of isregexop. That would make it slightly simpler to add the remaining shell wildcards ('?' and '[') when desired. '[' already works, if there's also a * to trigger expansion, with the small bug that special chars within [] still get escaped or translated so the set may include an unexpected '.' or '\'. Other regex chars also work, which probably should be counted as a bug. I assume the eventual goal is to behave just like a common shell.