From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH] dvb_usb_v2 [RFC] draft use delayed work.
Date: Thu, 14 Jun 2012 02:40:10 +0300 [thread overview]
Message-ID: <4FD924DA.5020206@iki.fi> (raw)
In-Reply-To: <1339626433.2421.76.camel@Route3278>
On 06/14/2012 01:27 AM, Malcolm Priestley wrote:
> dvb_usb_v2 [RFC] use delayed work.
>
> The problem with an ordinary work queue it executes immediately.
>
> changes made
> 1. Three extra states added DVB_USB_STATE_PROBE, DVB_USB_STATE_COLD
> and DVB_USB_STATE_WARM.
> 2. Initialise of priv moved to probe this shouldn't really be done in the
> work queue.
> 3. The initial delay 200ms waits for the probe to clear.
> 4. State DVB_USB_STATE_PROBE checks for interface to be BOUND then calls the
> identify_state(possibly extra timeout signals needed if binding fails).
> 5. The next schedule time now increases to 500ms execution following as before
> with state changing accordingly.
> 6. DVB_USB_STATE_INIT uses the value of 0x7 so clears the other states.
>
> The work queue then dies forever. However, it could continue on as the remote work.
One question before I start to review those changes: as I explained
firmware loading my earlier mail, are these changes valid any-more?
It sounds a little bit weird if I haven't meet these problems as I have
tested those using multiple devices. af9015, anysee, ec168, au6610 and
Cypress FX2 with warm/cold IDs.
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2012-06-13 23:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 22:27 [PATCH] dvb_usb_v2 [RFC] draft use delayed work Malcolm Priestley
2012-06-13 23:40 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD924DA.5020206@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.