diff for duplicates of <4FD98DDA.9050806@windriver.com> diff --git a/a/1.1.hdr b/a/1.1.hdr deleted file mode 100644 index eb03614..0000000 --- a/a/1.1.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/plain; charset="UTF-8"; format=flowed -Content-Transfer-Encoding: 8bit diff --git a/a/1.2.bin b/a/1.2.bin deleted file mode 100644 index f8b45ef..0000000 --- a/a/1.2.bin +++ /dev/null @@ -1,153 +0,0 @@ -<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> -<html> - <head> - <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> - </head> - <body bgcolor="#ffffff" text="#000000"> - 于 2012å¹´06月14æ—¥ 14:44, Igor Grinberg 写é“: - <blockquote cite="mid:4FD98856.8070601@compulab.co.il" type="cite"> - <div class="moz-text-plain" wrap="true" graphical-quote="true" - style="font-family: -moz-fixed; font-size: 12px;" - lang="x-unicode"> - <pre wrap="">On 06/14/12 07:46, Zumeng Chen wrote: -</pre> - <blockquote type="cite" style="color: rgb(0, 0, 0);"> - <pre wrap=""><span class="moz-txt-citetags">> </span>于 2012å¹´06月13æ—¥ 20:18, Hiremath, Vaibhav 写é“: -</pre> - <blockquote type="cite" style="color: rgb(0, 0, 0);"> - <pre wrap=""><span class="moz-txt-citetags">>> </span>On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote: -</pre> - <blockquote type="cite" style="color: rgb(0, 0, 0);"> - <pre wrap=""><span class="moz-txt-citetags">>>> </span>From: Zumeng Chen<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:zumeng.chen@windriver.com"><zumeng.chen@windriver.com></a> -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span>If we don't set proper debouce time for ads7846, then there are -<span class="moz-txt-citetags">>>> </span>flooded interrupt counters of ads7846 responding to one time -<span class="moz-txt-citetags">>>> </span>touch on screen, so the driver couldn't work well. -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span>And since most OMAP3 series boards pass NULL pointer of board_pdata -<span class="moz-txt-citetags">>>> </span>to omap_ads7846_init, so it's more proper to set it in driver level -<span class="moz-txt-citetags">>>> </span>after having gpio_request done. -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span>This patch has been validated on 3530evm. -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span>Signed-off-by: Zumeng Chen<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:zumeng.chen@windriver.com"><zumeng.chen@windriver.com></a> -<span class="moz-txt-citetags">>>> </span>Signed-off-by: Syed Mohammed Khasim<a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:khasim@ti.com"><khasim@ti.com></a> -<span class="moz-txt-citetags">>>> </span>--- -<span class="moz-txt-citetags">>>> </span> drivers/input/touchscreen/ads7846.c | 4 ++++ -<span class="moz-txt-citetags">>>> </span> 1 files changed, 4 insertions(+), 0 deletions(-) -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span>diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c -<span class="moz-txt-citetags">>>> </span>index f02028e..459ff29 100644 -<span class="moz-txt-citetags">>>> </span>--- a/drivers/input/touchscreen/ads7846.c -<span class="moz-txt-citetags">>>> </span>+++ b/drivers/input/touchscreen/ads7846.c -<span class="moz-txt-citetags">>>> </span>@@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784 -<span class="moz-txt-citetags">>>> </span> } -<span class="moz-txt-citetags">>>></span> -<span class="moz-txt-citetags">>>> </span> ts->gpio_pendown = pdata->gpio_pendown; -<span class="moz-txt-citetags">>>> </span>+#ifdef CONFIG_ARCH_OMAP3 -<span class="moz-txt-citetags">>>> </span>+ /* 310 means about 10 microsecond for omap3 */ -<span class="moz-txt-citetags">>>> </span>+ gpio_set_debounce(pdata->gpio_pendown, 310); -<span class="moz-txt-citetags">>>> </span>+#endif -<span class="moz-txt-citetags">>>></span> -</pre> - </blockquote> - <pre wrap=""><span class="moz-txt-citetags">>> </span>Zumeng, -<span class="moz-txt-citetags">>></span> -<span class="moz-txt-citetags">>> </span>With my sign-off you are changing the original code, that too -<span class="moz-txt-citetags">>> </span>without my sign-off and ack. -<span class="moz-txt-citetags">>> </span>I wouldn't mind you to submit patches from my tree, but the expectation is -<span class="moz-txt-citetags">>> </span>if you are changing the original code, it should be under your sign-off. -</pre> - </blockquote> - <pre wrap=""><span class="moz-txt-citetags">> </span>Thanks, good to learn. I'll remove in next time. -</pre> - <blockquote type="cite" style="color: rgb(0, 0, 0);"> - <pre wrap=""><span class="moz-txt-citetags">>> </span>Coming to the patch, #ifdef in driver is not recommended, and this 10msec -<span class="moz-txt-citetags">>> </span>delay is specific to OMAP GPIO and driver should not be aware of this, -<span class="moz-txt-citetags">>> </span>that's where you will find the original patch handling it in board file. -</pre> - </blockquote> - <pre wrap=""><span class="moz-txt-citetags">> </span>According to the git blame of the board-omap3evm.c I think -<span class="moz-txt-citetags">> </span>96974a24 did a good thing to all the related codes for omap3 -<span class="moz-txt-citetags">> </span>boards. So I think we can call board and driver as BSP level <span class="moz-smiley-s1" title=":-)"><span>:-)</span></span> -<span class="moz-txt-citetags">> </span> -<span class="moz-txt-citetags">> </span>If #ifdef in driver can save many codes, I guess it's deserved. -</pre> - </blockquote> - <pre wrap="">No, platform/board specific ifdefs in the generic driver code are never -deserved. -How about the attached patch, does it fix the problem for you? -</pre> - </div> - </blockquote> - Sorry Igor, I just read your patch, yes, most are there, and we<br> - just have to set get_pendown_state as you early said. Really<br> - *thanks* for your drive :)<br> - <br> - Regards,<br> - Zumeng<br> - <blockquote cite="mid:4FD98856.8070601@compulab.co.il" type="cite"> - <div class="moz-text-plain" wrap="true" graphical-quote="true" - style="font-family: -moz-fixed; font-size: 12px;" - lang="x-unicode"> - <pre wrap=""> -<div class="moz-txt-sig">-- -Regards, -Igor. -</div></pre> - </div> - <div class="moz-text-plain" wrap="true" graphical-quote="true" - style="font-family: -moz-fixed; font-size: 16px;" lang="zh-CN"> - <pre wrap=""> -<fieldset class="mimeAttachmentHeader"><legend class="mimeAttachmentName">ads7846.patch</legend></fieldset> -diff --git a/arch/arm/mach-omap2/common-board-devices.c b/arch/arm/mach-omap2/common-board-devices.c -index 1706ebc..c187586 100644 ---- a/arch/arm/mach-omap2/common-board-devices.c -+++ b/arch/arm/mach-omap2/common-board-devices.c -@@ -63,28 +63,30 @@ void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce, - struct spi_board_info *spi_bi = &ads7846_spi_board_info; - int err; - -- if (board_pdata && board_pdata->get_pendown_state) { -- err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown"); -- if (err) { -- pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err); -- return; -- } -- gpio_export(gpio_pendown, 0); -- -- if (gpio_debounce) -- gpio_set_debounce(gpio_pendown, gpio_debounce); -+ err = gpio_request_one(gpio_pendown, GPIOF_IN, "TSPenDown"); -+ if (err) { -+ pr_err("Couldn't obtain gpio for TSPenDown: %d\n", err); -+ return; - } - -+ if (gpio_debounce) -+ gpio_set_debounce(gpio_pendown, gpio_debounce); -+ - spi_bi->bus_num = bus_num; - spi_bi->irq = gpio_to_irq(gpio_pendown); - - if (board_pdata) { - board_pdata->gpio_pendown = gpio_pendown; - spi_bi->platform_data = board_pdata; -+ if (board_pdata->get_pendown_state) -+ gpio_export(gpio_pendown, 0); - } else { - ads7846_config.gpio_pendown = gpio_pendown; - } - -+ if (!board_pdata || (board_pdata && !board_pdata->get_pendown_state)) -+ gpio_free(gpio_pendown); -+ - spi_register_board_info(&ads7846_spi_board_info, 1); - } - #else -</pre> - </div> - </blockquote> - <br> - </body> -</html> diff --git a/a/1.2.hdr b/a/1.2.hdr deleted file mode 100644 index 80c528c..0000000 --- a/a/1.2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: text/html; charset="UTF-8" -Content-Transfer-Encoding: 8bit diff --git a/a/1.1.txt b/N1/1.txt similarity index 93% rename from a/1.1.txt rename to N1/1.txt index 5cd01c6..8336d47 100644 --- a/a/1.1.txt +++ b/N1/1.txt @@ -1,6 +1,6 @@ -于 2012年06月14日 14:44, Igor Grinberg 写道: +? 2012?06?14? 14:44, Igor Grinberg ??: > On 06/14/12 07:46, Zumeng Chen wrote: ->> > 于 2012年06月13日 20:18, Hiremath, Vaibhav 写道: +>> > ? 2012?06?13? 20:18, Hiremath, Vaibhav ??: >>> >> On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote: >>>> >>> From: Zumeng Chen<zumeng.chen@windriver.com> >>>> >>> @@ -106,3 +106,7 @@ Zumeng > spi_register_board_info(&ads7846_spi_board_info, 1); > } > #else + +-------------- next part -------------- +An HTML attachment was scrubbed... +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120614/23df068c/attachment-0001.html> diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 4b86001..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,4 +0,0 @@ -Content-Type: text/plain; charset="us-ascii" -MIME-Version: 1.0 -Content-Transfer-Encoding: 7bit -Content-Disposition: inline diff --git a/a/2.txt b/a/2.txt deleted file mode 100644 index 8133cf0..0000000 --- a/a/2.txt +++ /dev/null @@ -1,4 +0,0 @@ -_______________________________________________ -linux-arm-kernel mailing list -linux-arm-kernel@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index d2df0a2..6f766be 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,34 +1,18 @@ + "ref\0zumeng.chen@gmail.com\0" "ref\01339551850-20827-1-git-send-email-zumeng.chen@gmail.com\0" "ref\01339551850-20827-6-git-send-email-zumeng.chen@gmail.com\0" "ref\079CD15C6BA57404B839C016229A409A83EA4F07F@DBDE01.ent.ti.com\0" "ref\04FD96CBF.5040106@windriver.com\0" "ref\04FD98856.8070601@compulab.co.il\0" - "From\0Zumeng Chen <zumeng.chen@windriver.com>\0" - "Subject\0Re: [PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level\0" + "From\0zumeng.chen@windriver.com (Zumeng Chen)\0" + "Subject\0[PATCH V2 5/5] Input: ads7846: set proper debounce time in driver level\0" "Date\0Thu, 14 Jun 2012 15:08:10 +0800\0" - "To\0Igor Grinberg <grinberg@compulab.co.il>\0" - "Cc\0Hilman" - Kevin <khilman@ti.com> - linux-input@vger.kernel.org <linux-input@vger.kernel.org> - Zumeng Chen <zumeng.chen@gmail.com> - tony@atomide.com <tony@atomide.com> - dmitry.torokhov@gmail.com <dmitry.torokhov@gmail.com> - Hiremath - Vaibhav <hvaibhav@ti.com> - Gupta - Ajay Kumar <ajay.gupta@ti.com> - Syed Mohammed - Khasim <khasim@ti.com> - Hunter - Jon <jon-hunter@ti.com> - mike@compulab.co.il - linux-omap@vger.kernel.org <linux-omap@vger.kernel.org> - " linux-arm-kernel@lists.infradead.org <linux-arm-kernel@lists.infradead.org>\0" - "\02:1.1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" - "\344\272\216 2012\345\271\26406\346\234\21014\346\227\245 14:44, Igor Grinberg \345\206\231\351\201\223:\n" + "? 2012?06?14? 14:44, Igor Grinberg ??:\n" "> On 06/14/12 07:46, Zumeng Chen wrote:\n" - ">> > \344\272\216 2012\345\271\26406\346\234\21013\346\227\245 20:18, Hiremath, Vaibhav \345\206\231\351\201\223:\n" + ">> > ? 2012?06?13? 20:18, Hiremath, Vaibhav ??:\n" ">>> >> On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:\n" ">>>> >>> From: Zumeng Chen<zumeng.chen@windriver.com>\n" ">>>> >>>\n" @@ -133,167 +117,10 @@ "> +\n" "> \tspi_register_board_info(&ads7846_spi_board_info, 1);\n" "> }\n" - > #else - "\02:1.2\0" - "b\0" - "<!DOCTYPE HTML PUBLIC \"-//W3C//DTD HTML 4.01 Transitional//EN\">\n" - "<html>\n" - " <head>\n" - " <meta content=\"text/html; charset=UTF-8\" http-equiv=\"Content-Type\">\n" - " </head>\n" - " <body bgcolor=\"#ffffff\" text=\"#000000\">\n" - " \344\272\216 2012\345\271\26406\346\234\21014\346\227\245 14:44, Igor Grinberg \345\206\231\351\201\223:\n" - " <blockquote cite=\"mid:4FD98856.8070601@compulab.co.il\" type=\"cite\">\n" - " <div class=\"moz-text-plain\" wrap=\"true\" graphical-quote=\"true\"\n" - " style=\"font-family: -moz-fixed; font-size: 12px;\"\n" - " lang=\"x-unicode\">\n" - " <pre wrap=\"\">On 06/14/12 07:46, Zumeng Chen wrote:\n" - "</pre>\n" - " <blockquote type=\"cite\" style=\"color: rgb(0, 0, 0);\">\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">> </span>\344\272\216 2012\345\271\26406\346\234\21013\346\227\245 20:18, Hiremath, Vaibhav \345\206\231\351\201\223:\n" - "</pre>\n" - " <blockquote type=\"cite\" style=\"color: rgb(0, 0, 0);\">\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">>> </span>On Wed, Jun 13, 2012 at 07:14:10, Zumeng Chen wrote:\n" - "</pre>\n" - " <blockquote type=\"cite\" style=\"color: rgb(0, 0, 0);\">\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">>>> </span>From: Zumeng Chen<a moz-do-not-send=\"true\" class=\"moz-txt-link-rfc2396E\" href=\"mailto:zumeng.chen@windriver.com\"><zumeng.chen@windriver.com></a>\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span>If we don't set proper debouce time for ads7846, then there are\n" - "<span class=\"moz-txt-citetags\">>>> </span>flooded interrupt counters of ads7846 responding to one time\n" - "<span class=\"moz-txt-citetags\">>>> </span>touch on screen, so the driver couldn't work well.\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span>And since most OMAP3 series boards pass NULL pointer of board_pdata\n" - "<span class=\"moz-txt-citetags\">>>> </span>to omap_ads7846_init, so it's more proper to set it in driver level\n" - "<span class=\"moz-txt-citetags\">>>> </span>after having gpio_request done.\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span>This patch has been validated on 3530evm.\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span>Signed-off-by: Zumeng Chen<a moz-do-not-send=\"true\" class=\"moz-txt-link-rfc2396E\" href=\"mailto:zumeng.chen@windriver.com\"><zumeng.chen@windriver.com></a>\n" - "<span class=\"moz-txt-citetags\">>>> </span>Signed-off-by: Syed Mohammed Khasim<a moz-do-not-send=\"true\" class=\"moz-txt-link-rfc2396E\" href=\"mailto:khasim@ti.com\"><khasim@ti.com></a>\n" - "<span class=\"moz-txt-citetags\">>>> </span>---\n" - "<span class=\"moz-txt-citetags\">>>> </span> drivers/input/touchscreen/ads7846.c | 4 ++++\n" - "<span class=\"moz-txt-citetags\">>>> </span> 1 files changed, 4 insertions(+), 0 deletions(-)\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span>diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c\n" - "<span class=\"moz-txt-citetags\">>>> </span>index f02028e..459ff29 100644\n" - "<span class=\"moz-txt-citetags\">>>> </span>--- a/drivers/input/touchscreen/ads7846.c\n" - "<span class=\"moz-txt-citetags\">>>> </span>+++ b/drivers/input/touchscreen/ads7846.c\n" - "<span class=\"moz-txt-citetags\">>>> </span>@@ -980,6 +980,10 @@ static int __devinit ads7846_setup_pendown(struct spi_device *spi, struct ads784\n" - "<span class=\"moz-txt-citetags\">>>> </span> }\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "<span class=\"moz-txt-citetags\">>>> </span> ts->gpio_pendown = pdata->gpio_pendown;\n" - "<span class=\"moz-txt-citetags\">>>> </span>+#ifdef CONFIG_ARCH_OMAP3\n" - "<span class=\"moz-txt-citetags\">>>> </span>+ /* 310 means about 10 microsecond for omap3 */\n" - "<span class=\"moz-txt-citetags\">>>> </span>+ gpio_set_debounce(pdata->gpio_pendown, 310);\n" - "<span class=\"moz-txt-citetags\">>>> </span>+#endif\n" - "<span class=\"moz-txt-citetags\">>>></span>\n" - "</pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">>> </span>Zumeng,\n" - "<span class=\"moz-txt-citetags\">>></span>\n" - "<span class=\"moz-txt-citetags\">>> </span>With my sign-off you are changing the original code, that too\n" - "<span class=\"moz-txt-citetags\">>> </span>without my sign-off and ack.\n" - "<span class=\"moz-txt-citetags\">>> </span>I wouldn't mind you to submit patches from my tree, but the expectation is\n" - "<span class=\"moz-txt-citetags\">>> </span>if you are changing the original code, it should be under your sign-off.\n" - "</pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">> </span>Thanks, good to learn. I'll remove in next time.\n" - "</pre>\n" - " <blockquote type=\"cite\" style=\"color: rgb(0, 0, 0);\">\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">>> </span>Coming to the patch, #ifdef in driver is not recommended, and this 10msec\n" - "<span class=\"moz-txt-citetags\">>> </span>delay is specific to OMAP GPIO and driver should not be aware of this,\n" - "<span class=\"moz-txt-citetags\">>> </span>that's where you will find the original patch handling it in board file.\n" - "</pre>\n" - " </blockquote>\n" - " <pre wrap=\"\"><span class=\"moz-txt-citetags\">> </span>According to the git blame of the board-omap3evm.c I think\n" - "<span class=\"moz-txt-citetags\">> </span>96974a24 did a good thing to all the related codes for omap3\n" - "<span class=\"moz-txt-citetags\">> </span>boards. So I think we can call board and driver as BSP level <span class=\"moz-smiley-s1\" title=\":-)\"><span>:-)</span></span>\n" - "<span class=\"moz-txt-citetags\">> </span>\n" - "<span class=\"moz-txt-citetags\">> </span>If #ifdef in driver can save many codes, I guess it's deserved.\n" - "</pre>\n" - " </blockquote>\n" - " <pre wrap=\"\">No, platform/board specific ifdefs in the generic driver code are never\n" - "deserved.\n" - "How about the attached patch, does it fix the problem for you?\n" - "</pre>\n" - " </div>\n" - " </blockquote>\n" - " Sorry Igor, I just read your patch, yes, most are there, and we<br>\n" - " just have to set get_pendown_state as you early said. Really<br>\n" - " *thanks* for your drive :)<br>\n" - " <br>\n" - " Regards,<br>\n" - " Zumeng<br>\n" - " <blockquote cite=\"mid:4FD98856.8070601@compulab.co.il\" type=\"cite\">\n" - " <div class=\"moz-text-plain\" wrap=\"true\" graphical-quote=\"true\"\n" - " style=\"font-family: -moz-fixed; font-size: 12px;\"\n" - " lang=\"x-unicode\">\n" - " <pre wrap=\"\">\n" - "<div class=\"moz-txt-sig\">-- \n" - "Regards,\n" - "Igor.\n" - "</div></pre>\n" - " </div>\n" - " <div class=\"moz-text-plain\" wrap=\"true\" graphical-quote=\"true\"\n" - " style=\"font-family: -moz-fixed; font-size: 16px;\" lang=\"zh-CN\">\n" - " <pre wrap=\"\">\n" - "<fieldset class=\"mimeAttachmentHeader\"><legend class=\"mimeAttachmentName\">ads7846.patch</legend></fieldset>\n" - "diff --git a/arch/arm/mach-omap2/common-board-devices.c b/arch/arm/mach-omap2/common-board-devices.c\n" - "index 1706ebc..c187586 100644\n" - "--- a/arch/arm/mach-omap2/common-board-devices.c\n" - "+++ b/arch/arm/mach-omap2/common-board-devices.c\n" - "@@ -63,28 +63,30 @@ void __init omap_ads7846_init(int bus_num, int gpio_pendown, int gpio_debounce,\n" - " \tstruct spi_board_info *spi_bi = &ads7846_spi_board_info;\n" - " \tint err;\n" - " \n" - "-\tif (board_pdata && board_pdata->get_pendown_state) {\n" - "-\t\terr = gpio_request_one(gpio_pendown, GPIOF_IN, \"TSPenDown\");\n" - "-\t\tif (err) {\n" - "-\t\t\tpr_err(\"Couldn't obtain gpio for TSPenDown: %d\\n\", err);\n" - "-\t\t\treturn;\n" - "-\t\t}\n" - "-\t\tgpio_export(gpio_pendown, 0);\n" - "-\n" - "-\t\tif (gpio_debounce)\n" - "-\t\t\tgpio_set_debounce(gpio_pendown, gpio_debounce);\n" - "+\terr = gpio_request_one(gpio_pendown, GPIOF_IN, \"TSPenDown\");\n" - "+\tif (err) {\n" - "+\t\tpr_err(\"Couldn't obtain gpio for TSPenDown: %d\\n\", err);\n" - "+\t\treturn;\n" - " \t}\n" - " \t\n" - "+\tif (gpio_debounce)\n" - "+\t\tgpio_set_debounce(gpio_pendown, gpio_debounce);\n" - "+\n" - " \tspi_bi->bus_num\t= bus_num;\n" - " \tspi_bi->irq\t= gpio_to_irq(gpio_pendown);\n" - " \n" - " \tif (board_pdata) {\n" - " \t\tboard_pdata->gpio_pendown = gpio_pendown;\n" - " \t\tspi_bi->platform_data = board_pdata;\n" - "+\t\tif (board_pdata->get_pendown_state)\n" - "+\t\t\tgpio_export(gpio_pendown, 0);\n" - " \t} else {\n" - " \t\tads7846_config.gpio_pendown = gpio_pendown;\n" - " \t}\n" - " \n" - "+\tif (!board_pdata || (board_pdata && !board_pdata->get_pendown_state))\n" - "+\t\tgpio_free(gpio_pendown);\n" - "+\n" - " \tspi_register_board_info(&ads7846_spi_board_info, 1);\n" - " }\n" - " #else\n" - "</pre>\n" - " </div>\n" - " </blockquote>\n" - " <br>\n" - " </body>\n" - "</html>\n" - "\01:2\0" - "b\0" - "_______________________________________________\n" - "linux-arm-kernel mailing list\n" - "linux-arm-kernel@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/linux-arm-kernel + "> #else\n" + "\n" + "-------------- next part --------------\n" + "An HTML attachment was scrubbed...\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120614/23df068c/attachment-0001.html> -7c9f4d6275022baffaee355b76db0b1595aac0b0ed94a58903b16a9cc5e77efe +3106133f232a10294aff8305fe6ae03c3794d86da5c1c09a5ca28b3309a227a4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.