From: Paolo Bonzini <pbonzini@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>,
Andreas Faerber <andreas.faerber@web.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] qom: refactor Interfaces
Date: Thu, 14 Jun 2012 11:10:46 +0200 [thread overview]
Message-ID: <4FD9AA96.9010507@redhat.com> (raw)
In-Reply-To: <1339620902-4481-1-git-send-email-aliguori@us.ibm.com>
Il 13/06/2012 22:54, Anthony Liguori ha scritto:
> The interface implementation was pretty busted. The way it created Objects for
> each interface was extremely clumbsy and brittle.
>
> This is a new implementation that does something quite a bit more natural. It
> simply modifies classes such that they can affectively have more than one super
> class.
>
> Interfaces never get instantiated. Instead an object's class just refers to its
> parent class and it's implemented interfaces.
>
> This should solve the issues Peter's run into and also eliminate the recursive
> call to object_new() (its no longer necessary to allocate anything when creating
> an object).
>
> This also comes with a test case for object.
>
I gave it only a quick look, but the approach is much more sane.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
next prev parent reply other threads:[~2012-06-14 9:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 20:54 [Qemu-devel] [PATCH 0/3] qom: refactor Interfaces Anthony Liguori
2012-06-13 20:55 ` [Qemu-devel] [PATCH 1/3] tests: fix dependency inclusion Anthony Liguori
2012-06-14 13:08 ` Andreas Färber
2012-06-14 13:12 ` Paolo Bonzini
2012-06-13 20:55 ` [Qemu-devel] [PATCH 2/3] qom: reimplement Interfaces Anthony Liguori
2012-06-16 10:47 ` Peter Crosthwaite
2012-06-22 11:29 ` Peter Crosthwaite
2012-06-13 20:55 ` [Qemu-devel] [PATCH 3/3] qom: add unit test for Interfaces Anthony Liguori
2012-06-16 10:31 ` Peter Crosthwaite
2012-06-18 13:26 ` Anthony Liguori
2012-06-18 13:46 ` Peter Crosthwaite
2012-06-18 13:51 ` Andreas Färber
2012-06-18 14:54 ` Anthony Liguori
2012-06-14 9:10 ` Paolo Bonzini [this message]
2012-06-15 4:58 ` [Qemu-devel] [PATCH 0/3] qom: refactor Interfaces Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD9AA96.9010507@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=andreas.faerber@web.de \
--cc=peter.crosthwaite@petalogix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.