From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7Ar-0000rm-HE for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:21:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf7Al-0000uL-B1 for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:21:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44403) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf7Al-0000u8-3S for qemu-devel@nongnu.org; Thu, 14 Jun 2012 06:21:03 -0400 Message-ID: <4FD9BB06.3000509@redhat.com> Date: Thu, 14 Jun 2012 18:20:54 +0800 From: Amos Kong MIME-Version: 1.0 References: <433764b9-c58b-4b4e-8a4d-0f6cd84a25e7@zmail13.collab.prod.int.phx2.redhat.com> <4FD0326F.3010806@redhat.com> <20120611140642.06be2ee8@doriath.home> <4FD62827.4060900@us.ibm.com> <20120611142546.66871522@doriath.home> In-Reply-To: <20120611142546.66871522@doriath.home> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , qemu-devel@nongnu.org On 12/06/12 01:25, Luiz Capitulino wrote: >> Hi Luiz, Anthony >> BTW, why is there a 16 keycode limit? 'Sendkey' command was added by this commit a3a91a355bc6107b7d06d722fb97d2b80065ee0b Limitation of keycodes number (16) was also introduced here, and I didn't find the root reason. >> > That's a good point. This comes form the array used by the original > implementation to store the keycodes. > > Amos, is it still needed now that we're using qapi lists? I try to drop this limitation from monitor.c [1], then execute (qemu) sendkey 1-2-3-4-5-6-7-8-9-0-1-2-3-4-5-6-7-8-9-0 kbd_put_keycode() are called for all (20) keycodes, but only '123456789012345' can be sent to guest. It seems we need to notice user when inputted keys are more than 16. [1] https://github.com/kongove/QEMU/commit/a198cdcce3ce4c1632221ac7f1e7c4e8efcd9c82 -- Amos.