From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SfAFV-00061h-Ij for kexec@lists.infradead.org; Thu, 14 Jun 2012 13:38:10 +0000 Message-ID: <4FD9E936.3030001@redhat.com> Date: Thu, 14 Jun 2012 16:37:58 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [PATCH v2 3/5] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO References: <4FB35C48.30708@cn.fujitsu.com> <4FB35D60.6050009@cn.fujitsu.com> In-Reply-To: <4FB35D60.6050009@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: zhangyanfei Cc: dzickus@redhat.com, luto@mit.edu, kvm@vger.kernel.org, Joerg Roedel , mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, ebiederm@xmission.com, Greg KH T24gMDUvMTYvMjAxMiAxMDo1NSBBTSwgemhhbmd5YW5mZWkgd3JvdGU6Cj4gVGhpcyBwYXRjaCBp bXBsZW1lbnRzIGEgbmV3IG1vZHVsZSBuYW1lZCB2bWNzaW5mby1pbnRlbC4gVGhlCj4gbW9kdWxl IGZpbGxzIFZNQ1NJTkZPIHdpdGggdGhlIFZNQ1MgcmV2aXNpb24gaWRlbnRpZmllciwKPiBhbmQg ZW5jb2RlZCBvZmZzZXRzIG9mIFZNQ1MgZmllbGRzLgo+IAo+IE5vdGUsIG9mZnNldHMgb2YgZmll bGRzIGJlbG93IHdpbGwgbm90IGJlIGZpbGxlZCBpbnRvIFZNQ1NJTkZPOgo+IDEuIGZpZWxkcyBk ZWZpbmVkIGluIEludGVsIHNwZWNpZmljYXRpb24gKEludGVswq4gNjQgYW5kCj4gICAgSUEtMzIg QXJjaGl0ZWN0dXJlcyBTb2Z0d2FyZSBEZXZlbG9wZXLigJlzIE1hbnVhbCwgVm9sdW1lCj4gICAg M0MpIGJ1dCBub3QgZGVmaW5lZCBpbiAqdm1jc19maWVsZCouCj4gMi4gZmllbGRzIGRvbid0IGV4 aXN0IGJlY2F1c2UgdGhlaXIgY29ycmVzcG9uZGluZyBjb250cm9sIGJpdHMKPiAgICBhcmUgbm90 IHNldC4KPiAKPiArCj4gKy8qCj4gKyAqIFdlIHNlcGFyYXRlIHRoZXNlIGZpdmUgY29udHJvbCBm aWVsZHMgZnJvbSBvdGhlciBmaWVsZHMKPiArICogYmVjYXVzZSBzb21lIGZpZWxkcyBvbmx5IGV4 aXN0IG9uIHByb2Nlc3NvcnMgdGhhdCBzdXBwb3J0Cj4gKyAqIHRoZSAxLXNldHRpbmcgb2YgY29u dHJvbCBiaXRzIGluIHRoZSBmaXZlIGNvbnRyb2wgZmllbGRzLgo+ICsgKi8KCkkgdGhvdWdodCB0 aGlzIHdhcyBjaGVja2VkIG9ubHkgZHVyaW5nIFZNRU5UUlkuICBTbyBwZXJoYXBzIHlvdSBkb24n dApuZWVkIHRoaXMgc3BlY2lhbCBjYXNpbmcuCgpJbiBmYWN0IHlvdSBtaWdodCBiZSBhYmxlIHRv CgogICAvLyBwcmUtZmlsbCB2bWNzIHdpdGggcGF0dGVybnMKCiAgZm9yIChpID0gMDsgaSA8IDY0 azsgKytpKQogICAgICBpZiAodm1jc19yZWFkX2NoZWNraW5nKGksICZwYXR0ZXJuKSkgewogICAg ICAgICAgIC8vIGRlY29kZSBwYXR0ZXJuCiAgICAgIH0gZWxzZQogICAgICAgICAgIC8vIGZpZWxk IGRvZXMgbm90IGV4aXN0IChWTSBJbnN0cnVjdGlvbiBlcnJvciAxMiksIGlnbm9yZQoKd2l0aCBu byBrbm93bGVkZ2Ugb2YgdGhlIGNvbnRyb2wgZmllbGRzLCBvciBvZiBhbnkgZmllbGQgbmFtZS4K Cgo+ICsKPiArLyoKPiArICogVGhlIGZvcm1hdCBvZiBWTUNTSU5GTyBpcyBnaXZlbiBiZWxvdzoK PiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICog ICB8IEJ5dGUgb2Zmc2V0IHwgQ29udGVudHMgICAgICAgICAgICAgICAgIHwKPiArICogICArLS0t LS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICogICB8IDAgICAgICAg ICAgIHwgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVyIHwKPiArICogICArLS0tLS0tLS0tLS0tLSst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICogICB8IDQgICAgICAgICAgIHwgPGZpZWxk PjxlbmNvZGVkIG9mZnNldD4gIHwKPiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsKPiArICogICB8IDE2ICAgICAgICAgIHwgPGZpZWxkPjxlbmNvZGVkIG9m ZnNldD4gIHwKPiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSsKPiArICogICAuLi4uLi4KPiArICoKPiArICogVGhlIGZpcnN0IDMyIGJpdHMgb2YgVk1DU0lO Rk8gY29udGFpbnMgdGhlIFZNQ1MgcmV2aXNpb24KPiArICogaWRlbnRpZmllci4KPiArICogVGhl IHJlbWFpbmRlciBvZiBWTUNTSU5GTyBpcyB1c2VkIGZvciA8ZmllbGQ+PGVuY29kZWQgb2Zmc2V0 Pgo+ICsgKiBzZXRzLiBFYWNoIHNldCB0YWtlcyAxMiBieXRlczogZmllbGQgb2NjdXB5cyA0IGJ5 dGVzCj4gKyAqIGFuZCBpdHMgY29ycmVzcG9uZGluZyBlbmNvZGVkIG9mZnNldCBvY2N1cHlzIDgg Ynl0ZXMuCj4gKyAqCj4gKyAqIEVuY29kZWQgb2Zmc2V0cyBhcmUgcmF3IHZhbHVlcyByZWFkIGJ5 IHZtY3NfcmVhZHsxNiwgNjQsIDMyLCBsfSwKPiArICogYW5kIHRoZXkgYXJlIGFsbCB1bnNpZ25l ZCBleHRlbmRlZCB0byA4IGJ5dGVzIGZvciBlYWNoCj4gKyAqIDxmaWVsZD48ZW5jb2RlZCBvZmZz ZXQ+IHNldCBoYXMgdGhlIHNhbWUgc2l6ZS4KPiArICogV2UgZG8gbm90IGRlY29kZSBvZmZzZXRz IGhlcmUuIFRoZSBkZWNvZGluZyB3b3JrIGlzIGRlbGF5ZWQKPiArICogaW4gdXNlcnNwYWNlIHRv b2xzLgoKSXQncyBiZXR0ZXIgdG8gZG8gdGhlIGRlY29kaW5nIGhlcmUsIG9yIG5vIG9uZSB3aWxs IGtub3cgaG93IHRvIGRvIGl0LgpBbHNvIGhhdmUgYW4gbmZpZWxkcyBmaWVsZC4KLS0gCmVycm9y IGNvbXBpbGluZyBjb21taXR0ZWUuYzogdG9vIG1hbnkgYXJndW1lbnRzIHRvIGZ1bmN0aW9uCgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1h aWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 3/5] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO Date: Thu, 14 Jun 2012 16:37:58 +0300 Message-ID: <4FD9E936.3030001@redhat.com> References: <4FB35C48.30708@cn.fujitsu.com> <4FB35D60.6050009@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Joerg Roedel , mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, Greg KH To: zhangyanfei Return-path: In-Reply-To: <4FB35D60.6050009-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org T24gMDUvMTYvMjAxMiAxMDo1NSBBTSwgemhhbmd5YW5mZWkgd3JvdGU6Cj4gVGhpcyBwYXRjaCBp bXBsZW1lbnRzIGEgbmV3IG1vZHVsZSBuYW1lZCB2bWNzaW5mby1pbnRlbC4gVGhlCj4gbW9kdWxl IGZpbGxzIFZNQ1NJTkZPIHdpdGggdGhlIFZNQ1MgcmV2aXNpb24gaWRlbnRpZmllciwKPiBhbmQg ZW5jb2RlZCBvZmZzZXRzIG9mIFZNQ1MgZmllbGRzLgo+IAo+IE5vdGUsIG9mZnNldHMgb2YgZmll bGRzIGJlbG93IHdpbGwgbm90IGJlIGZpbGxlZCBpbnRvIFZNQ1NJTkZPOgo+IDEuIGZpZWxkcyBk ZWZpbmVkIGluIEludGVsIHNwZWNpZmljYXRpb24gKEludGVswq4gNjQgYW5kCj4gICAgSUEtMzIg QXJjaGl0ZWN0dXJlcyBTb2Z0d2FyZSBEZXZlbG9wZXLigJlzIE1hbnVhbCwgVm9sdW1lCj4gICAg M0MpIGJ1dCBub3QgZGVmaW5lZCBpbiAqdm1jc19maWVsZCouCj4gMi4gZmllbGRzIGRvbid0IGV4 aXN0IGJlY2F1c2UgdGhlaXIgY29ycmVzcG9uZGluZyBjb250cm9sIGJpdHMKPiAgICBhcmUgbm90 IHNldC4KPiAKPiArCj4gKy8qCj4gKyAqIFdlIHNlcGFyYXRlIHRoZXNlIGZpdmUgY29udHJvbCBm aWVsZHMgZnJvbSBvdGhlciBmaWVsZHMKPiArICogYmVjYXVzZSBzb21lIGZpZWxkcyBvbmx5IGV4 aXN0IG9uIHByb2Nlc3NvcnMgdGhhdCBzdXBwb3J0Cj4gKyAqIHRoZSAxLXNldHRpbmcgb2YgY29u dHJvbCBiaXRzIGluIHRoZSBmaXZlIGNvbnRyb2wgZmllbGRzLgo+ICsgKi8KCkkgdGhvdWdodCB0 aGlzIHdhcyBjaGVja2VkIG9ubHkgZHVyaW5nIFZNRU5UUlkuICBTbyBwZXJoYXBzIHlvdSBkb24n dApuZWVkIHRoaXMgc3BlY2lhbCBjYXNpbmcuCgpJbiBmYWN0IHlvdSBtaWdodCBiZSBhYmxlIHRv CgogICAvLyBwcmUtZmlsbCB2bWNzIHdpdGggcGF0dGVybnMKCiAgZm9yIChpID0gMDsgaSA8IDY0 azsgKytpKQogICAgICBpZiAodm1jc19yZWFkX2NoZWNraW5nKGksICZwYXR0ZXJuKSkgewogICAg ICAgICAgIC8vIGRlY29kZSBwYXR0ZXJuCiAgICAgIH0gZWxzZQogICAgICAgICAgIC8vIGZpZWxk IGRvZXMgbm90IGV4aXN0IChWTSBJbnN0cnVjdGlvbiBlcnJvciAxMiksIGlnbm9yZQoKd2l0aCBu byBrbm93bGVkZ2Ugb2YgdGhlIGNvbnRyb2wgZmllbGRzLCBvciBvZiBhbnkgZmllbGQgbmFtZS4K Cgo+ICsKPiArLyoKPiArICogVGhlIGZvcm1hdCBvZiBWTUNTSU5GTyBpcyBnaXZlbiBiZWxvdzoK PiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICog ICB8IEJ5dGUgb2Zmc2V0IHwgQ29udGVudHMgICAgICAgICAgICAgICAgIHwKPiArICogICArLS0t LS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICogICB8IDAgICAgICAg ICAgIHwgVk1DUyByZXZpc2lvbiBpZGVudGlmaWVyIHwKPiArICogICArLS0tLS0tLS0tLS0tLSst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsKPiArICogICB8IDQgICAgICAgICAgIHwgPGZpZWxk PjxlbmNvZGVkIG9mZnNldD4gIHwKPiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsKPiArICogICB8IDE2ICAgICAgICAgIHwgPGZpZWxkPjxlbmNvZGVkIG9m ZnNldD4gIHwKPiArICogICArLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSsKPiArICogICAuLi4uLi4KPiArICoKPiArICogVGhlIGZpcnN0IDMyIGJpdHMgb2YgVk1DU0lO Rk8gY29udGFpbnMgdGhlIFZNQ1MgcmV2aXNpb24KPiArICogaWRlbnRpZmllci4KPiArICogVGhl IHJlbWFpbmRlciBvZiBWTUNTSU5GTyBpcyB1c2VkIGZvciA8ZmllbGQ+PGVuY29kZWQgb2Zmc2V0 Pgo+ICsgKiBzZXRzLiBFYWNoIHNldCB0YWtlcyAxMiBieXRlczogZmllbGQgb2NjdXB5cyA0IGJ5 dGVzCj4gKyAqIGFuZCBpdHMgY29ycmVzcG9uZGluZyBlbmNvZGVkIG9mZnNldCBvY2N1cHlzIDgg Ynl0ZXMuCj4gKyAqCj4gKyAqIEVuY29kZWQgb2Zmc2V0cyBhcmUgcmF3IHZhbHVlcyByZWFkIGJ5 IHZtY3NfcmVhZHsxNiwgNjQsIDMyLCBsfSwKPiArICogYW5kIHRoZXkgYXJlIGFsbCB1bnNpZ25l ZCBleHRlbmRlZCB0byA4IGJ5dGVzIGZvciBlYWNoCj4gKyAqIDxmaWVsZD48ZW5jb2RlZCBvZmZz ZXQ+IHNldCBoYXMgdGhlIHNhbWUgc2l6ZS4KPiArICogV2UgZG8gbm90IGRlY29kZSBvZmZzZXRz IGhlcmUuIFRoZSBkZWNvZGluZyB3b3JrIGlzIGRlbGF5ZWQKPiArICogaW4gdXNlcnNwYWNlIHRv b2xzLgoKSXQncyBiZXR0ZXIgdG8gZG8gdGhlIGRlY29kaW5nIGhlcmUsIG9yIG5vIG9uZSB3aWxs IGtub3cgaG93IHRvIGRvIGl0LgpBbHNvIGhhdmUgYW4gbmZpZWxkcyBmaWVsZC4KLS0gCmVycm9y IGNvbXBpbGluZyBjb21taXR0ZWUuYzogdG9vIG1hbnkgYXJndW1lbnRzIHRvIGZ1bmN0aW9uCgoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmtleGVjIG1h aWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102Ab2FNNiP (ORCPT ); Thu, 14 Jun 2012 09:38:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42884 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756065Ab2FNNiN (ORCPT ); Thu, 14 Jun 2012 09:38:13 -0400 Message-ID: <4FD9E936.3030001@redhat.com> Date: Thu, 14 Jun 2012 16:37:58 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: zhangyanfei CC: mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, Joerg Roedel , dzickus@redhat.com, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org, Greg KH Subject: Re: [PATCH v2 3/5] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO References: <4FB35C48.30708@cn.fujitsu.com> <4FB35D60.6050009@cn.fujitsu.com> In-Reply-To: <4FB35D60.6050009@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/16/2012 10:55 AM, zhangyanfei wrote: > This patch implements a new module named vmcsinfo-intel. The > module fills VMCSINFO with the VMCS revision identifier, > and encoded offsets of VMCS fields. > > Note, offsets of fields below will not be filled into VMCSINFO: > 1. fields defined in Intel specification (Intel® 64 and > IA-32 Architectures Software Developer’s Manual, Volume > 3C) but not defined in *vmcs_field*. > 2. fields don't exist because their corresponding control bits > are not set. > > + > +/* > + * We separate these five control fields from other fields > + * because some fields only exist on processors that support > + * the 1-setting of control bits in the five control fields. > + */ I thought this was checked only during VMENTRY. So perhaps you don't need this special casing. In fact you might be able to // pre-fill vmcs with patterns for (i = 0; i < 64k; ++i) if (vmcs_read_checking(i, &pattern)) { // decode pattern } else // field does not exist (VM Instruction error 12), ignore with no knowledge of the control fields, or of any field name. > + > +/* > + * The format of VMCSINFO is given below: > + * +-------------+--------------------------+ > + * | Byte offset | Contents | > + * +-------------+--------------------------+ > + * | 0 | VMCS revision identifier | > + * +-------------+--------------------------+ > + * | 4 | | > + * +-------------+--------------------------+ > + * | 16 | | > + * +-------------+--------------------------+ > + * ...... > + * > + * The first 32 bits of VMCSINFO contains the VMCS revision > + * identifier. > + * The remainder of VMCSINFO is used for > + * sets. Each set takes 12 bytes: field occupys 4 bytes > + * and its corresponding encoded offset occupys 8 bytes. > + * > + * Encoded offsets are raw values read by vmcs_read{16, 64, 32, l}, > + * and they are all unsigned extended to 8 bytes for each > + * set has the same size. > + * We do not decode offsets here. The decoding work is delayed > + * in userspace tools. It's better to do the decoding here, or no one will know how to do it. Also have an nfields field. -- error compiling committee.c: too many arguments to function