From: Zach Brown <zab@zabbo.net>
To: Liu Bo <liubo2009@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/4] Btrfs: use radix tree for checksum
Date: Thu, 14 Jun 2012 09:42:26 -0700 [thread overview]
Message-ID: <4FDA1472.8020803@zabbo.net> (raw)
In-Reply-To: <4FD9437C.3070009@cn.fujitsu.com>
>>> + BUG_ON(ret);
>>
>> I wonder if we can patch BUG_ON() to break the build if its only
>> argument is "ret".
>>
>
> why?
Well, I'm mostly joking :). That would be a very silly change to make.
But only mostly joking. btrfs does have a real fragility problem from
all these incomplete error handling paths:
$ grep 'BUG_ON(ret.*)' fs/btrfs/*.c | wc -l
197
We should be fixing these, not adding more. I don't think any patches
should be merged which add more of these.
- z
next prev parent reply other threads:[~2012-06-14 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-13 10:19 [PATCH 0/4 v2][RFC] apply rwlock for extent state Liu Bo
2012-06-13 10:19 ` [PATCH 1/4] Btrfs: use radix tree for checksum Liu Bo
2012-06-13 16:07 ` Zach Brown
2012-06-14 1:50 ` Liu Bo
2012-06-14 16:42 ` Zach Brown [this message]
2012-07-06 15:37 ` Chris Mason
2012-07-07 7:43 ` Liu Bo
2012-06-14 15:03 ` David Sterba
2012-06-13 10:19 ` [PATCH 2/4] Btrfs: merge adjacent states as much as possible Liu Bo
2012-06-13 10:19 ` [PATCH 3/4] Btrfs: use large extent range for read and its endio Liu Bo
2012-06-14 16:12 ` David Sterba
2012-06-15 1:50 ` Liu Bo
2012-06-13 10:19 ` [PATCH 4/4] Btrfs: apply rwlock for extent state Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDA1472.8020803@zabbo.net \
--to=zab@zabbo.net \
--cc=linux-btrfs@vger.kernel.org \
--cc=liubo2009@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.