From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jonathan Kliegman <kliegs@chromium.org>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Will Newton <will.newton@imgtec.com>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] mmc: dw_mmc: Fix null dma_ops access when use_dma is false
Date: Fri, 15 Jun 2012 16:25:00 +0900 [thread overview]
Message-ID: <4FDAE34C.1030102@samsung.com> (raw)
In-Reply-To: <1339695115-606-1-git-send-email-kliegs@chromium.org>
It looks good to me.
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 06/15/2012 02:31 AM, Jonathan Kliegman wrote:
> host->dma_ops is not valid if host->usa dma is 0 so protect
> host->dma_ops reference in dw_mci_resume
>
> Signed-off-by: Jonathan Kliegman <kliegs@chromium.org>
> ---
> drivers/mmc/host/dw_mmc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1ca5e72..e2758d5 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2175,7 +2175,7 @@ int dw_mci_resume(struct dw_mci *host)
> return ret;
> }
>
> - if (host->dma_ops->init)
> + if (host->use_dma && host->dma_ops->init)
> host->dma_ops->init(host);
>
> /* Restore the old value at FIFOTH register */
next prev parent reply other threads:[~2012-06-15 7:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 17:31 [PATCH] mmc: dw_mmc: Fix null dma_ops access when use_dma is false Jonathan Kliegman
2012-06-15 7:25 ` Jaehoon Chung [this message]
2012-06-15 13:14 ` Will Newton
2012-06-20 6:34 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDAE34C.1030102@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=james.hogan@imgtec.com \
--cc=kliegs@chromium.org \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.