From: "Andreas Färber" <afaerber@suse.de>
To: Li Zhang <zhlcindy@linux.vnet.ibm.com>
Cc: aliguori@us.ibm.com, benh@au1.ibm.com, qemu-ppc@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb
Date: Fri, 15 Jun 2012 14:30:21 +0200 [thread overview]
Message-ID: <4FDB2ADD.9050503@suse.de> (raw)
In-Reply-To: <1339754783-14341-1-git-send-email-zhlcindy@linux.vnet.ibm.com>
Am 15.06.2012 12:06, schrieb Li Zhang:
> For pseries machine, it needs to enable usb to add
> keyboard or usb mouse. -usb option won't be used in
> the future, and machine options is a better way to
> enable usb.
>
> So this patch is to add usb option to machine options
> (-machine type=psereis,usb=on/off)to enable/disable
> usb controller.
>
> In this patch, usb_on is an global option which can
> be checked by machines.
[snip]
...which is exactly what you've been asked to change in v1. Please do.
Also please stick to QEMU Coding Style, which requires braces for if.
Use of the bool type is preferred of int for two-state logic.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-06-15 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 10:06 [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb Li Zhang
2012-06-15 12:04 ` Markus Armbruster
2012-06-15 13:08 ` Li Zhang
2012-06-15 14:34 ` Markus Armbruster
2012-06-18 2:17 ` Li Zhang
2012-06-18 7:29 ` Markus Armbruster
2012-06-18 7:54 ` Peter Crosthwaite
2012-06-18 8:24 ` Li Zhang
2012-06-18 9:22 ` [Qemu-devel] [PATCH 1/2] " Li Zhang
2012-06-18 9:26 ` 陳韋任 (Wei-Ren Chen)
2012-06-18 8:10 ` [Qemu-devel] [PATCHv2 1/1] " Li Zhang
2012-06-15 12:30 ` Andreas Färber [this message]
2012-06-15 13:11 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB2ADD.9050503@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=benh@au1.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.