From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] staging:iio: Remove superfluous flush_scheduled_work
Date: Fri, 15 Jun 2012 13:35:42 +0100 [thread overview]
Message-ID: <4FDB2C1E.3080202@cam.ac.uk> (raw)
In-Reply-To: <1339748968-4116-1-git-send-email-lars@metafoo.de>
On 6/15/2012 9:29 AM, Lars-Peter Clausen wrote:
> None of these drivers ever schedule any work, so there is no need to flush any
> scheduled work when the driver is removed.
>
Guessing these are left from pre threaded interrupt days...
Good spot.
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/accel/adis16209_core.c | 2 --
> drivers/staging/iio/accel/adis16220_core.c | 2 --
> drivers/staging/iio/accel/adis16240_core.c | 2 --
> drivers/staging/iio/gyro/adis16260_core.c | 2 --
> 4 files changed, 8 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/adis16209_core.c b/drivers/staging/iio/accel/adis16209_core.c
> index f6fd0d3..6fc426e 100644
> --- a/drivers/staging/iio/accel/adis16209_core.c
> +++ b/drivers/staging/iio/accel/adis16209_core.c
> @@ -606,8 +606,6 @@ static int adis16209_remove(struct spi_device *spi)
> {
> struct iio_dev *indio_dev = spi_get_drvdata(spi);
>
> - flush_scheduled_work();
> -
> iio_device_unregister(indio_dev);
> adis16209_remove_trigger(indio_dev);
> iio_buffer_unregister(indio_dev);
> diff --git a/drivers/staging/iio/accel/adis16220_core.c b/drivers/staging/iio/accel/adis16220_core.c
> index 6a9ac89..af5c576 100644
> --- a/drivers/staging/iio/accel/adis16220_core.c
> +++ b/drivers/staging/iio/accel/adis16220_core.c
> @@ -694,8 +694,6 @@ static int adis16220_remove(struct spi_device *spi)
> {
> struct iio_dev *indio_dev = spi_get_drvdata(spi);
>
> - flush_scheduled_work();
> -
> sysfs_remove_bin_file(&indio_dev->dev.kobj,&adc2_bin);
> sysfs_remove_bin_file(&indio_dev->dev.kobj,&adc1_bin);
> sysfs_remove_bin_file(&indio_dev->dev.kobj,&accel_bin);
> diff --git a/drivers/staging/iio/accel/adis16240_core.c b/drivers/staging/iio/accel/adis16240_core.c
> index 8b15eae..2f59f83 100644
> --- a/drivers/staging/iio/accel/adis16240_core.c
> +++ b/drivers/staging/iio/accel/adis16240_core.c
> @@ -641,8 +641,6 @@ static int adis16240_remove(struct spi_device *spi)
>
> struct iio_dev *indio_dev = spi_get_drvdata(spi);
>
> - flush_scheduled_work();
> -
> iio_device_unregister(indio_dev);
> adis16240_remove_trigger(indio_dev);
> iio_buffer_unregister(indio_dev);
> diff --git a/drivers/staging/iio/gyro/adis16260_core.c b/drivers/staging/iio/gyro/adis16260_core.c
> index ec765f9..fdb84cc 100644
> --- a/drivers/staging/iio/gyro/adis16260_core.c
> +++ b/drivers/staging/iio/gyro/adis16260_core.c
> @@ -728,8 +728,6 @@ static int adis16260_remove(struct spi_device *spi)
> if (ret)
> goto err_ret;
>
> - flush_scheduled_work();
> -
> adis16260_remove_trigger(indio_dev);
> iio_buffer_unregister(indio_dev);
> adis16260_unconfigure_ring(indio_dev);
next prev parent reply other threads:[~2012-06-15 12:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-15 8:29 [PATCH] staging:iio: Remove superfluous flush_scheduled_work Lars-Peter Clausen
2012-06-15 12:35 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-15 16:14 Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDB2C1E.3080202@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.