All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/4] staging:iio:adis16400: Fix ADIS16334 temperature address
Date: Fri, 15 Jun 2012 13:40:00 +0100	[thread overview]
Message-ID: <4FDB2D20.3000502@cam.ac.uk> (raw)
In-Reply-To: <1339748926-4002-3-git-send-email-lars@metafoo.de>

On 6/15/2012 9:28 AM, Lars-Peter Clausen wrote:
> The channel spec for ADUS16334's temperature channel uses the address and scan
> index for the Z-axis acceleration channel. This patch fixes it to use the
> temperature channel address and scan index instead.
>
doh, that one is particularly bad (and obvious!)  Thanks,
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
>   drivers/staging/iio/imu/adis16400_core.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/iio/imu/adis16400_core.c b/drivers/staging/iio/imu/adis16400_core.c
> index 1c9931e..7aa3a9a 100644
> --- a/drivers/staging/iio/imu/adis16400_core.c
> +++ b/drivers/staging/iio/imu/adis16400_core.c
> @@ -1054,8 +1054,8 @@ static const struct iio_chan_spec adis16334_channels[] = {
>   		.info_mask = IIO_CHAN_INFO_RAW_SEPARATE_BIT |
>   		IIO_CHAN_INFO_CALIBBIAS_SEPARATE_BIT |
>   		IIO_CHAN_INFO_SCALE_SHARED_BIT,
> -		.address = accel_z,
> -		.scan_index = ADIS16400_SCAN_ACC_Z,
> +		.address = temp0,
> +		.scan_index = ADIS16400_SCAN_TEMP,
>   		.scan_type = IIO_ST('s', 14, 16, 0),
>   	},
>   	IIO_CHAN_SOFT_TIMESTAMP(12)


  reply	other threads:[~2012-06-15 12:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-15  8:28 [PATCH 1/4] staging:iio:adis16400: Fix ADIS16300 ROLL_OUT register address Lars-Peter Clausen
2012-06-15  8:28 ` [PATCH 2/4] staging:iio:adis16400: Fix ADIS16300 temperature address Lars-Peter Clausen
2012-06-15 12:39   ` Jonathan Cameron
2012-06-15  8:28 ` [PATCH 3/4] staging:iio:adis16400: Fix ADIS16334 " Lars-Peter Clausen
2012-06-15 12:40   ` Jonathan Cameron [this message]
2012-06-15  8:28 ` [PATCH 4/4] staging:iio:adis16400: Fix ADIS163xx AUX_ADC address Lars-Peter Clausen
2012-06-15 12:40   ` Jonathan Cameron
2012-06-15 12:38 ` [PATCH 1/4] staging:iio:adis16400: Fix ADIS16300 ROLL_OUT register address Jonathan Cameron
  -- strict thread matches above, loose matches on Subject: below --
2012-06-15 16:11 Lars-Peter Clausen
2012-06-15 16:11 ` [PATCH 3/4] staging:iio:adis16400: Fix ADIS16334 temperature address Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDB2D20.3000502@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.