From: Jiang Liu <jiang.liu@huawei.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Don Dutile <ddutile@redhat.com>,
Yijing Wang <wangyijing@huawei.com>,
Keping Chen <chenkeping@huawei.com>, <linux-pci@vger.kernel.org>,
Jiang Liu <liuj97@gmail.com>
Subject: Re: [PATCH v7 08/10] PCI, x86: add MMCFG information on demand
Date: Sat, 16 Jun 2012 17:23:16 +0800 [thread overview]
Message-ID: <4FDC5084.6090504@huawei.com> (raw)
In-Reply-To: <CAE9FiQVWhSZBcZM1DXJaN7rsj64YO=OjzOm6XkUqio5fZ5di+w@mail.gmail.com>
On 2012-6-16 0:51, Yinghai Lu wrote:
>
> still have some problem:
> pci_mmcfg_check_reserved==>is_mmconf_reserved
>
> will update cfg->end_bus.
Hi Yinghai,
How about following patch for this issue? I guess we need to
keep current behavior at boot time for backward compatibility, right?
---
@@ -472,6 +472,14 @@ static int __devinit is_mmconf_reserved(check_reserved_t is_reserved,
break;
}
+ /*
+ * For backward compatibility, we will adjust the MMCONFIG region
+ * at boot time if it's only partially reserved by firmware.
+ * For PCI host bridge hotplug at runtime, just reject it.
+ */
+ if (pci_mmcfg_running_state && old_size != size)
+ return 0;
+
if (size < (16UL<<20) && size != old_size)
return 0;
---
>
> Thanks
>
> Yinghai
>
> .
>
next prev parent reply other threads:[~2012-06-16 9:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-26 9:53 [PATCH v7 00/10] PCI, x86: update MMCFG information when hot-plugging PCI host bridges Jiang Liu
2012-05-26 9:53 ` [PATCH v7 01/10] PCI, x86: split out pci_mmcfg_check_reserved() for code reuse Jiang Liu
2012-05-26 9:53 ` [PATCH v7 02/10] PCI, x86: split out pci_mmconfig_alloc() " Jiang Liu
2012-05-26 9:53 ` [PATCH v7 03/10] PCI, x86: use RCU list to protect mmconfig list Jiang Liu
2012-05-26 9:53 ` [PATCH v7 04/10] PCI, x86: introduce pci_mmcfg_arch_map()/pci_mmcfg_arch_unmap() Jiang Liu
2012-05-26 9:53 ` [PATCH v7 05/10] PCI, x86: introduce pci_mmconfig_insert()/delete() for PCI root bridge hotplug Jiang Liu
2012-05-26 9:53 ` [PATCH v7 06/10] PCI, ACPI: provide MCFG address for PCI host bridges Jiang Liu
2012-05-26 9:54 ` [PATCH v7 07/10] PCI, x86: update MMCFG information when hot-plugging " Jiang Liu
2012-05-26 9:54 ` [PATCH v7 08/10] PCI, x86: add MMCFG information on demand Jiang Liu
2012-06-15 7:15 ` Yinghai Lu
2012-06-15 8:13 ` Jiang Liu
2012-06-15 11:50 ` Jiang Liu
2012-06-15 16:51 ` Yinghai Lu
2012-06-16 9:23 ` Jiang Liu [this message]
2012-06-16 20:08 ` Yinghai Lu
2012-06-16 21:48 ` Bjorn Helgaas
2012-06-16 22:44 ` Yinghai Lu
2012-06-16 22:48 ` Yinghai Lu
2012-06-17 1:55 ` Bjorn Helgaas
2012-06-18 1:21 ` Jiang Liu
2012-06-18 18:24 ` Bjorn Helgaas
2012-06-15 15:46 ` Bjorn Helgaas
2012-06-15 16:34 ` Jiang Liu
2012-06-15 16:55 ` Yinghai Lu
2012-06-16 8:58 ` Jiang Liu
2012-05-26 9:54 ` [PATCH v7 09/10] PCI, x86: simplify pci_mmcfg_late_insert_resources() Jiang Liu
2012-05-26 9:54 ` [PATCH v7 10/10] PCI, x86: get rid of redundant log messages Jiang Liu
2012-06-05 2:59 ` [PATCH v7 00/10] PCI, x86: update MMCFG information when hot-plugging PCI host bridges Taku Izumi
2012-06-15 3:06 ` Bjorn Helgaas
2012-06-15 7:16 ` Yinghai Lu
2012-06-15 11:42 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDC5084.6090504@huawei.com \
--to=jiang.liu@huawei.com \
--cc=bhelgaas@google.com \
--cc=chenkeping@huawei.com \
--cc=ddutile@redhat.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-pci@vger.kernel.org \
--cc=liuj97@gmail.com \
--cc=wangyijing@huawei.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.