All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Ying Han <yinghan@google.com>
Cc: Michal Hocko <mhocko@suse.cz>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Rik van Riel <riel@redhat.com>, Hillf Danton <dhillf@gmail.com>,
	Hugh Dickins <hughd@google.com>, Greg Thelen <gthelen@google.com>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org
Subject: Re: [PATCH 2/5] mm: memcg set soft_limit_in_bytes to 0 by default
Date: Mon, 18 Jun 2012 11:43:22 +0900	[thread overview]
Message-ID: <4FDE95CA.80809@jp.fujitsu.com> (raw)
In-Reply-To: <1339007023-10467-1-git-send-email-yinghan@google.com>

(2012/06/07 3:23), Ying Han wrote:
> This idea is based on discussion with Michal and Johannes from LSF.
> 
> 1. If soft_limit are all set to MAX, it wastes first three priority iterations
> without scanning anything.
> 
> 2. By default every memcg is eligible for softlimit reclaim, and we can also
> set the value to MAX for special memcg which is immune to soft limit reclaim.
> 
> There is a behavior change after this patch: (N == DEF_PRIORITY - 2)
> 
>          A: usage>  softlimit        B: usage<= softlimit        U: softlimit unset
> old:    reclaim at each priority    reclaim when priority<  N    reclaim when priority<  N
> new:    reclaim at each priority    reclaim when priority<  N    reclaim at each priority
> 
> Note: I can leave the counter->soft_limit uninitialized, at least all the
> caller of res_counter_init() have the memcg as pre-zeroed structure. However, I
> might be better not rely on that.
> 
> Signed-off-by: Ying Han<yinghan@google.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2012-06-18  2:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 18:23 [PATCH 2/5] mm: memcg set soft_limit_in_bytes to 0 by default Ying Han
2012-06-18  2:43 ` Kamezawa Hiroyuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FDE95CA.80809@jp.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=dhillf@gmail.com \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=riel@redhat.com \
    --cc=yinghan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.