From: Avi Kivity <avi@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alex Williamson <alex.williamson@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mtosatti@redhat.com" <mtosatti@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"yongjie.ren@intel.com" <yongjie.ren@intel.com>
Subject: Re: [PATCH] KVM: Use IRQF_ONESHOT for assigned device MSI interrupts
Date: Mon, 18 Jun 2012 14:00:56 +0300 [thread overview]
Message-ID: <4FDF0A68.7080004@redhat.com> (raw)
In-Reply-To: <20120611102139.GA31197@redhat.com>
On 06/11/2012 01:21 PM, Michael S. Tsirkin wrote:
> On Mon, Jun 11, 2012 at 01:01:41PM +0300, Avi Kivity wrote:
>> On 06/08/2012 05:50 PM, Jan Kiszka wrote:
>> >
>> >>
>> >> Pls correct me if I'm wrong.
>> >
>> > Well, IIRC, the "don't loop over all vcpus with IRQs or preemption
>> > disabled" was one argument against direct legacy interrupt injection as
>> > well. That's what I kept in mind from those discussions. Maybe Avi can
>> > comment on the current position.
>>
>> It's still my position.
>>
>> IMO we need something like struct gfn_to_hva_cache for interrupts. If
>> it's in the cache, we fast-path it from the interrupt handler. If not,
>> fall back to a workqueue and let it refill the cache.
>
> And you class the irqfd behaviour of injecting multicast
> with interrupts disabled a bug then?
Yes (a minor one).
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-06-18 11:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 16:16 [PATCH] KVM: Use IRQF_ONESHOT for assigned device MSI interrupts Alex Williamson
2012-06-01 16:39 ` Jan Kiszka
2012-06-01 17:03 ` Alex Williamson
2012-06-01 17:14 ` Jan Kiszka
2012-06-01 17:59 ` Alex Williamson
2012-06-01 18:26 ` Jan Kiszka
2012-06-03 8:42 ` Avi Kivity
2012-06-04 11:21 ` Thomas Gleixner
2012-06-04 11:40 ` Jan Kiszka
2012-06-04 13:07 ` Thomas Gleixner
2012-06-04 13:16 ` Jan Kiszka
2012-06-04 13:22 ` Thomas Gleixner
2012-06-08 7:47 ` Michael S. Tsirkin
2012-06-08 7:55 ` Jan Kiszka
2012-06-08 8:00 ` Michael S. Tsirkin
2012-06-08 8:03 ` Jan Kiszka
2012-06-08 14:39 ` Michael S. Tsirkin
2012-06-08 14:50 ` Jan Kiszka
2012-06-11 10:01 ` Avi Kivity
2012-06-11 10:21 ` Michael S. Tsirkin
2012-06-18 8:46 ` Ren, Yongjie
2012-06-18 11:00 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FDF0A68.7080004@redhat.com \
--to=avi@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=tglx@linutronix.de \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.