Re: [Powertop] Please revert the workload patch

[Dirk Brandewie <dirk.brandewie at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1395 bytes --]

Hi Magnus,

This patch should fix your problem.  I will work with Chris to get it
pushed out.

BTW could not find the commit you quoted

--Dirk

diff --git a/src/main.cpp b/src/main.cpp
index 880d745..c57c984 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -452,7 +452,7 @@ int main(int argc, char **argv)

  	while (!leave_powertop) {
  		show_cur_tab();
-		one_measurement(time_out, workload);
+		one_measurement(time_out, NULL);
  		learn_parameters(15, 0);
  	}
  #ifndef DISABLE_NCURSES
-- 
1.7.7.6


On 06/16/2012 04:16 AM, Magnus Fromreide wrote:
> Hello.
>
> Could you please revert the workload patch
> (b45a38317777678b94cdf4cc81896e3a66db68bd) as it seems to try to
> execute some random memory. When powertop is started as
>
> ./powertop
>
> I see the following stack trace:
>
> Breakpoint 1, system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
> 29      pt-system.c: No such file or directory.
> (gdb) where
> #0  system (line=0x7fffffffd440 "\020\020i") at pt-system.c:29
> #1  0x0000000000456933 in one_measurement (seconds=20, workload=0x7fffffffd440 "\020\020i") at main.cpp:190
> #2  0x00000000004572c2 in main (argc=1, argv=0x7fffffffe538) at main.cpp:455
> (gdb)
>
> This shows up as a powertop beeing nonresponsive, flashing the
> display excessively and warning about not managing to run the program.
>
> /MF
>
>