From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kamezawa Hiroyuki Subject: Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() Date: Tue, 19 Jun 2012 09:11:20 +0900 Message-ID: <4FDFC3A8.7010301@jp.fujitsu.com> References: <1340015298-14133-1-git-send-email-glommer@parallels.com> <1340015298-14133-6-git-send-email-glommer@parallels.com> <4FDF1A0D.6080204@jp.fujitsu.com> <4FDF1AAE.4080209@parallels.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FDF1AAE.4080209-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Glauber Costa Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Pekka Enberg , Cristoph Lameter , David Rientjes , cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Frederic Weisbecker , Suleiman Souhlal , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko (2012/06/18 21:10), Glauber Costa wrote: > On 06/18/2012 04:07 PM, Kamezawa Hiroyuki wrote: >> (2012/06/18 19:27), Glauber Costa wrote: >>> Right now we free struct memcg with kfree right after a >>> rcu grace period, but defer it if we need to use vfree() to get >>> rid of that memory area. We do that by need, because we need vfree >>> to be called in a process context. >>> >>> This patch unifies this behavior, by ensuring that even kfree will >>> happen in a separate thread. The goal is to have a stable place to >>> call the upcoming jump label destruction function outside the realm >>> of the complicated and quite far-reaching cgroup lock (that can't be >>> held when calling neither the cpu_hotplug.lock nor the jump_label_mutex) >>> >>> Signed-off-by: Glauber Costa >>> CC: Tejun Heo >>> CC: Li Zefan >>> CC: Kamezawa Hiroyuki >>> CC: Johannes Weiner >>> CC: Michal Hocko >> >> How about cut out this patch and merge first as simple cleanu up and >> to reduce patch stack on your side ? >> >> Acked-by: KAMEZAWA Hiroyuki > > I believe this is already in the -mm tree (from the sock memcg fixes) > > But actually, my main trouble with this series here, is that I am basing > it on Pekka's tree, while some of the fixes are in -mm already. > If I'd base it on -mm I would lose some of the stuff as well. > > Maybe Pekka can merge the current -mm with his tree? > > So far I am happy with getting comments from people about the code, so I > did not get overly concerned about that. > Sure. thank you. -Kame From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx154.postini.com [74.125.245.154]) by kanga.kvack.org (Postfix) with SMTP id A59F16B0062 for ; Mon, 18 Jun 2012 20:13:45 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id 294123EE0B5 for ; Tue, 19 Jun 2012 09:13:44 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0454945DEBE for ; Tue, 19 Jun 2012 09:13:44 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id E28BA45DEB8 for ; Tue, 19 Jun 2012 09:13:43 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id D57221DB803C for ; Tue, 19 Jun 2012 09:13:43 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 8872D1DB8040 for ; Tue, 19 Jun 2012 09:13:43 +0900 (JST) Message-ID: <4FDFC3A8.7010301@jp.fujitsu.com> Date: Tue, 19 Jun 2012 09:11:20 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() References: <1340015298-14133-1-git-send-email-glommer@parallels.com> <1340015298-14133-6-git-send-email-glommer@parallels.com> <4FDF1A0D.6080204@jp.fujitsu.com> <4FDF1AAE.4080209@parallels.com> In-Reply-To: <4FDF1AAE.4080209@parallels.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: linux-mm@kvack.org, Pekka Enberg , Cristoph Lameter , David Rientjes , cgroups@vger.kernel.org, devel@openvz.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Suleiman Souhlal , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko (2012/06/18 21:10), Glauber Costa wrote: > On 06/18/2012 04:07 PM, Kamezawa Hiroyuki wrote: >> (2012/06/18 19:27), Glauber Costa wrote: >>> Right now we free struct memcg with kfree right after a >>> rcu grace period, but defer it if we need to use vfree() to get >>> rid of that memory area. We do that by need, because we need vfree >>> to be called in a process context. >>> >>> This patch unifies this behavior, by ensuring that even kfree will >>> happen in a separate thread. The goal is to have a stable place to >>> call the upcoming jump label destruction function outside the realm >>> of the complicated and quite far-reaching cgroup lock (that can't be >>> held when calling neither the cpu_hotplug.lock nor the jump_label_mutex) >>> >>> Signed-off-by: Glauber Costa >>> CC: Tejun Heo >>> CC: Li Zefan >>> CC: Kamezawa Hiroyuki >>> CC: Johannes Weiner >>> CC: Michal Hocko >> >> How about cut out this patch and merge first as simple cleanu up and >> to reduce patch stack on your side ? >> >> Acked-by: KAMEZAWA Hiroyuki > > I believe this is already in the -mm tree (from the sock memcg fixes) > > But actually, my main trouble with this series here, is that I am basing > it on Pekka's tree, while some of the fixes are in -mm already. > If I'd base it on -mm I would lose some of the stuff as well. > > Maybe Pekka can merge the current -mm with his tree? > > So far I am happy with getting comments from people about the code, so I > did not get overly concerned about that. > Sure. thank you. -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753471Ab2FSANq (ORCPT ); Mon, 18 Jun 2012 20:13:46 -0400 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:45084 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752943Ab2FSANp (ORCPT ); Mon, 18 Jun 2012 20:13:45 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v1.7.4 Message-ID: <4FDFC3A8.7010301@jp.fujitsu.com> Date: Tue, 19 Jun 2012 09:11:20 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.0; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Glauber Costa CC: linux-mm@kvack.org, Pekka Enberg , Cristoph Lameter , David Rientjes , cgroups@vger.kernel.org, devel@openvz.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Suleiman Souhlal , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko Subject: Re: [PATCH v4 05/25] memcg: Always free struct memcg through schedule_work() References: <1340015298-14133-1-git-send-email-glommer@parallels.com> <1340015298-14133-6-git-send-email-glommer@parallels.com> <4FDF1A0D.6080204@jp.fujitsu.com> <4FDF1AAE.4080209@parallels.com> In-Reply-To: <4FDF1AAE.4080209@parallels.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2012/06/18 21:10), Glauber Costa wrote: > On 06/18/2012 04:07 PM, Kamezawa Hiroyuki wrote: >> (2012/06/18 19:27), Glauber Costa wrote: >>> Right now we free struct memcg with kfree right after a >>> rcu grace period, but defer it if we need to use vfree() to get >>> rid of that memory area. We do that by need, because we need vfree >>> to be called in a process context. >>> >>> This patch unifies this behavior, by ensuring that even kfree will >>> happen in a separate thread. The goal is to have a stable place to >>> call the upcoming jump label destruction function outside the realm >>> of the complicated and quite far-reaching cgroup lock (that can't be >>> held when calling neither the cpu_hotplug.lock nor the jump_label_mutex) >>> >>> Signed-off-by: Glauber Costa >>> CC: Tejun Heo >>> CC: Li Zefan >>> CC: Kamezawa Hiroyuki >>> CC: Johannes Weiner >>> CC: Michal Hocko >> >> How about cut out this patch and merge first as simple cleanu up and >> to reduce patch stack on your side ? >> >> Acked-by: KAMEZAWA Hiroyuki > > I believe this is already in the -mm tree (from the sock memcg fixes) > > But actually, my main trouble with this series here, is that I am basing > it on Pekka's tree, while some of the fixes are in -mm already. > If I'd base it on -mm I would lose some of the stuff as well. > > Maybe Pekka can merge the current -mm with his tree? > > So far I am happy with getting comments from people about the code, so I > did not get overly concerned about that. > Sure. thank you. -Kame