From: Avi Kivity <avi@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Vijay Bellur <vbellur@redhat.com>,
Amar Tumballi <amarts@redhat.com>,
qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend
Date: Tue, 19 Jun 2012 12:27:04 +0300 [thread overview]
Message-ID: <4FE045E8.6040803@redhat.com> (raw)
In-Reply-To: <CAJSP0QXRdEtzqeWYSv6gzgwkP1LT+TDDUEEMpbiB1P9EbLvFAQ@mail.gmail.com>
On 06/18/2012 08:35 PM, Stefan Hajnoczi wrote:
> On Mon, Jun 11, 2012 at 3:21 PM, Bharata B Rao
> <bharata@linux.vnet.ibm.com> wrote:
>> +#include "block_int.h"
>> +#include "gluster-helpers.h"
>> +
>> +typedef void *gluster_file_t;
>
> This typedef is already in gluster-helpers.h. It's ugly BTW, "typedef
> struct gluster_file gluster_file_t" is nicer since it won't cast to
> other pointer types automatically.
gluster_file_t can only be cast to a NACK since names ending with _t are
reserved by the C runtime.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-06-19 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:18 [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU Bharata B Rao
2012-06-11 14:19 ` [Qemu-devel] [RFC PATCH 1/3] qemu: Add a config option for GlusterFS as block backend Bharata B Rao
2012-06-11 14:20 ` [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs Bharata B Rao
2012-06-18 17:35 ` Stefan Hajnoczi
2012-06-19 9:31 ` Bharata B Rao
2012-07-02 9:52 ` Paolo Bonzini
2012-07-02 10:05 ` Bharata B Rao
2012-06-11 14:21 ` [Qemu-devel] [RFC PATCH 3/3] block: gluster as block backend Bharata B Rao
2012-06-18 17:35 ` Stefan Hajnoczi
2012-06-19 9:27 ` Avi Kivity [this message]
2012-06-19 9:30 ` Bharata B Rao
2012-06-19 11:05 ` Stefan Hajnoczi
2012-07-01 14:50 ` Paolo Bonzini
2012-07-01 14:49 ` Paolo Bonzini
2012-06-18 15:36 ` [Qemu-devel] [RFC PATCH 0/3] GlusterFS support in QEMU Stefan Hajnoczi
2012-06-19 9:10 ` Bharata B Rao
2012-07-06 5:35 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE045E8.6040803@redhat.com \
--to=avi@redhat.com \
--cc=amarts@redhat.com \
--cc=bharata@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vbellur@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.