From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46474)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sh0IP-0008UH-M9
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 11:24:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sh0IJ-00070a-9I
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 11:24:45 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34620 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sh0IJ-00070M-2f
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 11:24:39 -0400
Message-ID: <4FE099B2.1060504@suse.de>
Date: Tue, 19 Jun 2012 17:24:34 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339686873-5528-1-git-send-email-afaerber@suse.de>
	<CAFEAcA_u164U-Px2DpxSofyQU8xyiP3J6SyuOuaG834HUXZW2g@mail.gmail.com>
In-Reply-To: <CAFEAcA_u164U-Px2DpxSofyQU8xyiP3J6SyuOuaG834HUXZW2g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of
 linux-headers/ build directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 19.06.2012 17:18, schrieb Peter Maydell:
> On 14 June 2012 16:14, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Commit ec5b06d (configure: ensure directory exists when creating symli=
nks)
>> moved the creation of directories into the symlink() function but forg=
ot
>> the case where no symlink is created.
>>
>> This leads to build errors on arm Linux due to -I../linux-headers.
>>
>> Unbreak the build on arm Linux by reverting part of that commit.
>=20
> I think it would be better to just revert ec5b06d completely.
> The comment documenting the symlink() function says
> "# symbolically link $1 to $2.  Portable version of "ln -sf"
> and "ln -sf" doesn't create the target directory, so symlink()
> should not either.

I don't mind either way as long as the build gets fixed. Anthony?

/-F

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg