Re: [PATCH V2 3/3] ARM: dts: db8500: add node property "regulator-compatible" regulator node

[Lee Jones <lee.jones@linaro.org>]

On 19/06/12 15:28, Laxman Dewangan wrote:
> Device's regulator matches their hardware counterparts with the
> property "regulator-compatible" of each child regulator node in
> place of the child node.
> Add the property "regulator-compatible" for each regulator with
> their name.
>
> Signed-off-by: Laxman Dewangan<ldewangan@nvidia.com>
> ---
> Changes from V1:
>   - This is new change in V2.
>
>   arch/arm/boot/dts/db8500.dtsi |  128 +++++++++++++++++++++++++++++++----------
>   1 files changed, 97 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/boot/dts/db8500.dtsi b/arch/arm/boot/dts/db8500.dtsi
> index 4ad5160..9548f80 100644
> --- a/arch/arm/boot/dts/db8500.dtsi
> +++ b/arch/arm/boot/dts/db8500.dtsi
> @@ -203,107 +203,149 @@
>
>   			db8500-prcmu-regulators {
>   				compatible = "stericsson,db8500-prcmu-regulator";
> +				#address-cells =<1>;
> +				#size-cells =<0>;

Why are these and the reg properties required?

>   				// DB8500_REGULATOR_VAPE
> -				db8500_vape_reg: db8500_vape {
> +				db8500_vape_reg: regulator@0 {
> +					reg =<0>;
> +					regulator-compatible = "db8500_vape";
>   					regulator-name = "db8500-vape";
>   					regulator-always-on;
>   				};

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog