Re: [Qemu-devel] [PATCH v12 02/13] Add migration capabilites

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On 06/19/2012 09:43 AM, Orit Wasserman wrote:
> Add migration capabiltes that can be queried by the management.

s/capabiltes/capabilities/

> The managment can query the source QEMU and the destination QEMU in order to

s/managment/management/

> verify both support some  migration capability (currently only XBZRLE).
> The managment can enable a capabilty for the next migration by using

s/managment/management/
s/capabilty/capability/

> migrate_set_parameter command.
> 

> +
> +STEXI
> +@item migrate_set_parameter @var{capabilty} @var{state}

s/capabilty/capability/

> +@findex migrate_set_parameter
> +Enable/Disable the usage of a capability @var{capabilty} for migration.

s/capabilty/capability/

> +##
> +# @migrate_set_parameters
> +#
> +# Set the following migration parameters (like xbzrle )

s/ )/)/

> +Example:
> +
> +-> { "execute": "query-migration-capabilities"}
> +<- { "return": { "xbzrle" }

s/}/} }/

Also, this doesn't match the earlier statement that this would be an
array of MigrationCapabilityInfo, in which case this would be:

{ "return": [ { "capability": "xbzrle", "state": true } ] }

or, someday in the future,

{ "return": [ { "capability": "xbzrle", "state": true },
              { "capability": "foobar", "state": false } ] }

> +Example:
> +
> +-> { "execute": "migrate_set_parameters" , "arguments": { "parameters": xbzrle on"} }

Also wrong.  Given the syntax, this would be:

{ "execute": "migrate-set-parameters", "arguments":
  { "parameters": [ { "capability": "xbzrle", "state": true } ] } }

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]