From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Sh5Oe-0000MO-Pw
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 16:51:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Sh5Od-0005ma-1D
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 16:51:32 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1Sh5Oc-0005mJ-Qq
	for qemu-devel@nongnu.org; Tue, 19 Jun 2012 16:51:30 -0400
Message-ID: <4FE0E64F.8050304@weilnetz.de>
Date: Tue, 19 Jun 2012 22:51:27 +0200
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <chegu_vinod@hp.com>
	<1339963951-7798-1-git-send-email-chegu_vinod@hp.com>
	<4FDFA633.7090505@suse.de> <4FDFA791.9020909@redhat.com>
	<4FE0638F.9080200@hp.com>
	<20120619203502.GB5073@otherpad.lan.raisama.net>
In-Reply-To: <20120619203502.GB5073@otherpad.lan.raisama.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Fixes related to processing of qemu's
 -numa option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Eric Blake <eblake@redhat.com>, Chegu Vinod <chegu_vinod@hp.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, QEMU Developers <qemu-devel@nongnu.org>

qemu-devel was no longer cc'ed, let us add it again.

Cheers,
Stefan

Am 19.06.2012 22:35, schrieb Eduardo Habkost:
> On Tue, Jun 19, 2012 at 04:33:35AM -0700, Chegu Vinod wrote:
> [...]
>    
>>>>> +#include<sched.h>
>>>>>            
>>>> Did you check whether this and the macros you're using are available on
>>>> POSIX and mingw32? vl.c is a pretty central file.
>>>>          
>>> POSIX, yes.  mingw32, no.  Use of preprocessor conditionals is probably
>>> in order.
>>>        
> [...]
>    
>> I started looking at this yesterday and quickly realized that even if
>> I did what I think Eric suggested (see below)
>> we won't be solving the underlying issue of going beyond 64VCPUs
>>
>> #ifndef __MINGW32__
>>
>> //use the macros
>>
>> #else
>>
>> // do without the macros...i.e. use current way (which goes upto 64way after
>> //   fixing the typecasting issue)
>>
>> #endif
>>
>>
>> Looking for other suggestions (besides having to write our own flavor
>> of the the macros
>> from scratch).
>>      
> You can use the bitmap functions at bitmap.{h,c} instead of cpu_set_t.
>
>